Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 2282563004: Do not exclude the last revision in the range returned by gitiles. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect/bisector.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/bisector.py b/scripts/slave/recipe_modules/auto_bisect/bisector.py
index 861ebbdc174bef0ecb9c06f02dd3be49413c7f1d..bac78edaf6b3e5f77a776c810b81d2e3e19c5d22 100644
--- a/scripts/slave/recipe_modules/auto_bisect/bisector.py
+++ b/scripts/slave/recipe_modules/auto_bisect/bisector.py
@@ -377,12 +377,13 @@ class Bisector(object):
start=good_hash,
end=bad_hash,
depot_name=self.base_depot,
- step_name=step_name)
+ step_name=step_name,
+ exclude_end=True)
self.revisions = [self.good_rev] + revisions + [self.bad_rev]
self._update_revision_list_indexes()
def _revision_range(self, start, end, depot_name, base_revision=None,
- step_name=None):
+ step_name=None, exclude_end=False):
dtu 2016/08/26 01:16:56 The skeleton has a similar parameter, but phrased
RobertoCN 2016/08/26 18:17:36 Acknowledged.
"""Returns a list of RevisionState objects between |start| and |end|.
Args:
@@ -408,7 +409,10 @@ class Bisector(object):
self.surface_result('BAD_REV')
raise
revisions = []
- for commit_hash, _ in step_result.stdout:
+ revision_hashes = step_result.stdout
+ if exclude_end:
+ revision_hashes = revision_hashes[:-1]
+ for commit_hash, _ in revision_hashes:
revisions.append(self.revision_class(
bisector=self,
commit_hash=commit_hash,

Powered by Google App Engine
This is Rietveld 408576698