Store hashes in CTLogVerifierTest as char arrays rather than hex

Store hashes in CTLogVerifierTest as char arrays rather than hex

Avoids the performance impact of decoding hex strings.
The impact is relatively small, however, so the value of this change is
debatable.

[Rob Percival, 2016-08-25 21:14:19]

The CQ bit was checked by robpercival@chromium.org to run a CQ dry run

[Rob Percival, 2016-08-25 21:14:32]

robpercival@chromium.org changed reviewers:
+ rsleevi@chromium.org

[commit-bot: I haz the power, 2016-08-25 21:15:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Rob Percival, 2016-08-25 21:17:12]

I'm still converting into std::string almost immediately, since CTLogVerifier
and other CT code take their hash arguments as std::string so the conversion has
to happen sooner or later.

[Rob Percival, 2016-08-25 21:30:34]

Patchset #1 (id:1) has been deleted

[Rob Percival, 2016-08-25 21:30:44]

The CQ bit was checked by robpercival@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 21:31:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 22:25:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 22:25:16]

Dry run: This issue passed the CQ dry run.

[Ryan Sleevi, 2016-09-01 00:48:47]

lgtm

[Ryan Sleevi, 2016-09-01 00:49:13]

As for value, I thought you were saying you observed 1s of difference due to the
many permutations of the test.

[Rob Percival, 2016-09-02 16:50:17]

On 2016/09/01 00:49:13, Ryan Sleevi (slow) wrote:
> As for value, I thought you were saying you observed 1s of difference due to
the
> many permutations of the test.

The hash of an empty tree was the only one of these hard-coded hashes that was
used in the tests
with many permutations. There was certainly a performance gain from eliminating
the many HexToBytes
calls performed when transforming that. The rest are used only a handful of
times, so the benefit is
far less noticeable.

[Rob Percival, 2016-09-28 13:53:26]

The CQ bit was checked by robpercival@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 13:53:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 13:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 13:55:29]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Rob Percival, 2016-10-20 14:44:54]

Patchset #2 (id:40001) has been deleted

[Rob Percival, 2016-12-21 10:28:53]

Description was changed from

==========
Store hashes in CTLogVerifierTest as char arrays rather than hex

Avoids the performance impact of decoding hex strings.
The impact is relatively small, however, so the value of this change is
debatable.
==========

to

==========
Store hashes in CTLogVerifierTest as char arrays rather than hex

Avoids the performance impact of decoding hex strings.
The impact is relatively small, however, so the value of this change is
debatable.
==========