Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ui/base/cocoa/defaults_utils.mm

Issue 2282533002: mac: use NSUserDefaults values for caret blink rate if present (Closed)
Patch Set: 10.9 support and comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/cocoa/defaults_utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/cocoa/defaults_utils.mm
diff --git a/ui/base/cocoa/defaults_utils.mm b/ui/base/cocoa/defaults_utils.mm
new file mode 100644
index 0000000000000000000000000000000000000000..814c766ffb60e6d6126500ebcc0818353d7f42eb
--- /dev/null
+++ b/ui/base/cocoa/defaults_utils.mm
@@ -0,0 +1,41 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <AppKit/AppKit.h>
+
+#include "base/logging.h"
+#include "ui/base/cocoa/defaults_utils.h"
+
+namespace ui {
+
+bool TextInsertionCaretBlinkPeriod(base::TimeDelta* delta) {
+ const int kMaximumReasonableIntervalMs = 60 * 1000;
+ NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+ double on_period_ms = [defaults
+ doubleForKey:@"NSTextInsertionPointBlinkPeriodOn"];
+ double off_period_ms = [defaults
+ doubleForKey:@"NSTextInsertionPointBlinkPeriodOff"];
+ double period_ms = [defaults
+ doubleForKey:@"NSTextInsertionPointBlinkPeriod"];
Nico 2016/08/25 19:59:12 Add comment "// 10.9" and add comment "// 10.10+"
+ if (on_period_ms == 0.0 && off_period_ms == 0.0 && period_ms == 0.0)
+ return false;
+ // Neither Blink nor Views support having separate on and off intervals, so
+ // this function takes the average. There's a special case: setting
+ // on_period_ms very high functions to permanently enable the cursor, which is
+ // what happens when the blink period in Blink/Views is set to 0. Setting
+ // off_period_ms very high would disable the cursor entirely, but Blink/Views
+ // do not support that so it's not implemented here.
+ if (on_period_ms > kMaximumReasonableIntervalMs ||
+ period_ms > kMaximumReasonableIntervalMs) {
+ *delta = base::TimeDelta();
+ } else if (on_period_ms || off_period_ms) {
+ *delta = base::TimeDelta::FromMillisecondsD(
+ (on_period_ms + off_period_ms) / 2);
+ } else {
+ *delta = base::TimeDelta::FromMilliseconds(period_ms);
+ }
+ return true;
+}
+
+} // namespace ui
« no previous file with comments | « ui/base/cocoa/defaults_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698