mac: use NSUserDefaults values for caret blink rate if present

mac: use NSUserDefaults values for caret blink rate if present

The main use of these by end-users is to disable cursor blink by setting them
to extremely large values.

BUG=500168
Committed: https://crrev.com/d0fd7b1437e5a3ffa87c7e5d9c28aefd4d6a826b
Cr-Commit-Position: refs/heads/master@{#414752}

[Elly Fong-Jones, 2016-08-25 19:29:14]

Description was changed from

==========
mac: use NSUserDefaults values for caret blink rate if present

The main use of these by end-users is to disable cursor blink by setting them
to extremely large values.

BUG=500168
==========

to

==========
mac: use NSUserDefaults values for caret blink rate if present

The main use of these by end-users is to disable cursor blink by setting them
to extremely large values.

BUG=500168
==========

[Elly Fong-Jones, 2016-08-25 19:29:14]

ellyjones@chromium.org changed reviewers:
+ thakis@chromium.org

[Elly Fong-Jones, 2016-08-25 19:31:02]

thakis: ptal? :)

[Nico, 2016-08-25 19:40:37]

https://codereview.chromium.org/2282533002/diff/20001/ui/base/cocoa/defaults_...
File ui/base/cocoa/defaults_utils.mm (right):

https://codereview.chromium.org/2282533002/diff/20001/ui/base/cocoa/defaults_...
ui/base/cocoa/defaults_utils.mm:18:
floatForKey:@"NSTextInsertionPointBlinkPeriodOff"];
apparently it's NSTextInsertionPointBlinkPeriod in older os x'en, do we want to
query that too?

https://codereview.chromium.org/2282533002/diff/20001/ui/base/cocoa/defaults_...
ui/base/cocoa/defaults_utils.mm:23: if (on_period_ms >
kMaximumReasonableIntervalMs) {
why check this for on_period_ms but not off_period_ms? I would've expected

  on_period_ms = min(on_period_ms, kMaximumReasonableIntervalMs);
  off_period_ms = min(off_period_ms, kMaximumReasonableIntervalMs);

  *delta = base::TimeDelta::FromMillisecondsD(
        (on_period_ms + off_period_ms) / 2);

[Elly Fong-Jones, 2016-08-25 19:57:34]

ptal? :)

https://codereview.chromium.org/2282533002/diff/20001/ui/base/cocoa/defaults_...
File ui/base/cocoa/defaults_utils.mm (right):

https://codereview.chromium.org/2282533002/diff/20001/ui/base/cocoa/defaults_...
ui/base/cocoa/defaults_utils.mm:18:
floatForKey:@"NSTextInsertionPointBlinkPeriodOff"];
On 2016/08/25 19:40:37, Nico wrote:
> apparently it's NSTextInsertionPointBlinkPeriod in older os x'en, do we want
to
> query that too?

Done.

https://codereview.chromium.org/2282533002/diff/20001/ui/base/cocoa/defaults_...
ui/base/cocoa/defaults_utils.mm:23: if (on_period_ms >
kMaximumReasonableIntervalMs) {
On 2016/08/25 19:40:37, Nico wrote:
> why check this for on_period_ms but not off_period_ms? I would've expected
> 
>   on_period_ms = min(on_period_ms, kMaximumReasonableIntervalMs);
>   off_period_ms = min(off_period_ms, kMaximumReasonableIntervalMs);
> 
>   *delta = base::TimeDelta::FromMillisecondsD(
>         (on_period_ms + off_period_ms) / 2);

Added explanation

[Nico, 2016-08-25 19:59:12]

lgtm

https://codereview.chromium.org/2282533002/diff/40001/ui/base/cocoa/defaults_...
File ui/base/cocoa/defaults_utils.mm (right):

https://codereview.chromium.org/2282533002/diff/40001/ui/base/cocoa/defaults_...
ui/base/cocoa/defaults_utils.mm:20:
doubleForKey:@"NSTextInsertionPointBlinkPeriod"];
Add comment "// 10.9" and add comment "// 10.10+" above the other two

[Elly Fong-Jones, 2016-08-26 17:00:33]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-08-26 17:00:33]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2282533002/#ps60001
(title: "more comments!")

[commit-bot: I haz the power, 2016-08-26 17:01:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 18:26:50]

Description was changed from

==========
mac: use NSUserDefaults values for caret blink rate if present

The main use of these by end-users is to disable cursor blink by setting them
to extremely large values.

BUG=500168
==========

to

==========
mac: use NSUserDefaults values for caret blink rate if present

The main use of these by end-users is to disable cursor blink by setting them
to extremely large values.

BUG=500168
==========

[commit-bot: I haz the power, 2016-08-26 18:26:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-26 18:30:23]

Description was changed from

==========
mac: use NSUserDefaults values for caret blink rate if present

The main use of these by end-users is to disable cursor blink by setting them
to extremely large values.

BUG=500168
==========

to

==========
mac: use NSUserDefaults values for caret blink rate if present

The main use of these by end-users is to disable cursor blink by setting them
to extremely large values.

BUG=500168

Committed: https://crrev.com/d0fd7b1437e5a3ffa87c7e5d9c28aefd4d6a826b
Cr-Commit-Position: refs/heads/master@{#414752}
==========

[commit-bot: I haz the power, 2016-08-26 18:30:24]

Patchset 4 (id:??) landed as
https://crrev.com/d0fd7b1437e5a3ffa87c7e5d9c28aefd4d6a826b
Cr-Commit-Position: refs/heads/master@{#414752}