Issue 228253003: Update usb charging command to wait for it to succeed.

Issue 228253003: Update usb charging command to wait for it to succeed. (Closed)

Created:
6 years, 8 months ago by qsr

Modified:
6 years, 8 months ago

Reviewers:
Philippe, tonyg

CC:
chromium-reviews, klundberg+watch_chromium.org, telemetry+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update usb charging command to wait for it to succeed. R=tonyg@chromium.org,pliard@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262512

Patch Set 2 : Follow review #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -10 lines)			Patch
	M	build/android/pylib/android_commands.py	View	1	1 chunk	+18 lines, -2 lines	0 comments	Download
	M	tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py	View	1	2 chunks	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Philippe

lgtm, thanks Ben! https://codereview.chromium.org/228253003/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/228253003/diff/1/build/android/pylib/android_commands.py#newcode1895 build/android/pylib/android_commands.py:1895: if 'true' == line.split('powered: ')[1]: Nit: ...

6 years, 8 months ago (2014-04-08 11:27:08 UTC) #2

tonyg

lgtm https://codereview.chromium.org/228253003/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py (right): https://codereview.chromium.org/228253003/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py#newcode38 tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py:38: if self._adb.IsDeviceCharging(self): I don't think you need the ...

6 years, 8 months ago (2014-04-08 15:04:13 UTC) #3

qsr

https://codereview.chromium.org/228253003/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/228253003/diff/1/build/android/pylib/android_commands.py#newcode1895 build/android/pylib/android_commands.py:1895: if 'true' == line.split('powered: ')[1]: On 2014/04/08 11:27:08, Philippe ...

6 years, 8 months ago (2014-04-08 15:37:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/228253003/20001

6 years, 8 months ago (2014-04-08 15:37:31 UTC) #6

Message was sent while issue was closed.

Change committed as 262512

Expand Messages | Collapse Messages