Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 2282523002: Cleanup by removing thread hop resource throttle code; experiment's over. (Closed)

Created:
4 years, 3 months ago by Randy Smith (Not in Mondays)
Modified:
4 years, 3 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup by removing thread hop resource throttle code; experiment's over. BUG=572740 R=davidben@chromium.org Committed: https://crrev.com/4c8cbb226aafb942b8978a0c4eb57605460c3c56 Cr-Commit-Position: refs/heads/master@{#414729}

Patch Set 1 #

Patch Set 2 : Remove stale include reference. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -108 lines) Patch
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/browser/renderer_host/thread_hop_resource_throttle.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/renderer_host/thread_hop_resource_throttle.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
Randy Smith (Not in Mondays)
David: PTAL?
4 years, 3 months ago (2016-08-25 20:17:08 UTC) #7
davidben
lgtm!
4 years, 3 months ago (2016-08-25 21:04:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282523002/20001
4 years, 3 months ago (2016-08-25 21:09:39 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/246453)
4 years, 3 months ago (2016-08-25 21:18:44 UTC) #14
Randy Smith (Not in Mondays)
jochen@: Would you be willing to review and stamp? Robert, could you review histograms.xml?
4 years, 3 months ago (2016-08-25 21:34:09 UTC) #16
rkaplow
lgtm
4 years, 3 months ago (2016-08-26 12:56:43 UTC) #17
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-26 15:01:36 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282523002/20001
4 years, 3 months ago (2016-08-26 15:57:18 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 16:33:39 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 16:35:44 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c8cbb226aafb942b8978a0c4eb57605460c3c56
Cr-Commit-Position: refs/heads/master@{#414729}

Powered by Google App Engine
This is Rietveld 408576698