Uses an object pool on x64

runtime/vm/assembler_x64.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ASSEMBLER_X64_H_
 #define VM_ASSEMBLER_X64_H_
 
 #ifndef VM_ASSEMBLER_H_
 #error Do not include assembler_x64.h directly; use assembler.h instead.
 #endif
@@ skipping 303 matching lines @@
 
   static bool sse4_1_supported_;
 #ifdef DEBUG
   static bool initialized_;
 #endif
 };
 
 
 class Assembler : public ValueObject {
  public:
-  explicit Assembler(bool use_far_branches = false)
-      : buffer_(),
-        object_pool_(GrowableObjectArray::Handle()),
-        prologue_offset_(-1),
-        comments_() {
-    // This mode is only needed and implemented for MIPS and ARM.
-    ASSERT(!use_far_branches);
-  }
+  explicit Assembler(bool use_far_branches = false);
+
   ~Assembler() { }
 
   static const bool kNearJump = true;
   static const bool kFarJump = false;
 
   /*
    * Emit Machine Instructions.
    */
   void call(Register reg);
   void call(const Address& address);
   void call(Label* label);
   void call(const ExternalLabel* label);
 
-  static const intptr_t kCallExternalLabelSize = 13;
+  static const intptr_t kCallExternalLabelSize = 10;
 
   void pushq(Register reg);
   void pushq(const Address& address);
   void pushq(const Immediate& imm);
 
   void popq(Register reg);
   void popq(const Address& address);
 
   void setcc(Condition condition, ByteRegister dst);
 
@@ skipping 289 matching lines @@
   void CompareRegisters(Register a, Register b);
 
   // Issues a move instruction if 'to' is not the same as 'from'.
   void MoveRegister(Register to, Register from);
   void PopRegister(Register r);
 
   void AddImmediate(Register reg, const Immediate& imm);
 
   void Drop(intptr_t stack_elements);
 
-  void LoadObject(Register dst, const Object& object);
+  enum Patchability {
+    kPatchable,
+    kNotPatchable,
+  };
+
+  int32_t AddObject(const Object& obj);
+  int32_t AddExternalLabel(const ExternalLabel* label,
+                           Patchability patchable = kPatchable);
+  bool CanLoadFromObjectPool(const Object& object);

[Florian Schneider, 2013/09/04 09:39:47]

I don't see this function used anywhere outside the Assembler class: I'd make it
private.

[zra, 2013/09/04 21:00:41]

Done.

+  void LoadWordFromPoolOffset(Register dst, Register pp, int32_t offset,

[Florian Schneider, 2013/09/04 09:39:47]

I don't see this function used anywhere outside the Assembler class: I'd make it
private.

[zra, 2013/09/04 21:00:41]

Done.

+                              Patchability patchable);
+  void LoadExternalLabel(const ExternalLabel* label,

[Florian Schneider, 2013/09/04 09:39:47]

I don't see this function used anywhere outside the Assembler class: I'd make it
private and remove the optional arguments.

[zra, 2013/09/04 21:00:41]

Done.

+                         Patchability = kPatchable,

[Florian Schneider, 2013/09/04 09:39:47]

Max one optional argument, and only if absolutely necessary.

[zra, 2013/09/04 21:00:41]

Done.

+                         Register pp = PP);
+
+  // Load object into register dst. The default patchability is kPatchable
+  // because LoadObject is used for a load of ic-data in arch independent code
+  // that must be patchable.
+  void LoadObject(Register dst, const Object& object,
+                  Patchability patchable = kPatchable, Register pp = PP);

[Florian Schneider, 2013/09/04 09:39:47]

Max one optional argument, and only if absolutely necessary.

[zra, 2013/09/04 21:00:41]

Done.

+  void JumpPatchable(const ExternalLabel* label, Register pp = PP);
+  void JumpFromPool(const ExternalLabel* label, Register pp = PP);
+  void JumpFromPool(Condition condition, const ExternalLabel* label,
+                    Register pp = PP);
+  void CallPatchable(const ExternalLabel* label);
+  void CallFromPool(const ExternalLabel* label);
   void StoreObject(const Address& dst, const Object& obj);
   void PushObject(const Object& object);
   void CompareObject(Register reg, const Object& object);
   void LoadDoubleConstant(XmmRegister dst, double value);
 
   // Destroys value.
   void StoreIntoObject(Register object,  // Object we are storing into.
                        const Address& dest,  // Where we are storing into.
                        Register value,  // Value we are storing.
                        bool can_value_be_smi = true);
 
   void StoreIntoObjectNoBarrier(Register object,
                                 const Address& dest,
                                 Register value);
 
   void DoubleNegate(XmmRegister d);
   void FloatNegate(XmmRegister f);
 
   void DoubleAbs(XmmRegister reg);
 
   void LockCmpxchgl(const Address& address, Register reg) {
     lock();
     cmpxchgl(address, reg);
   }
 
   void EnterFrame(intptr_t frame_space);
-  void LeaveFrame();
+  void LeaveFrame(bool restore_pp = false);

[Florian Schneider, 2013/09/04 09:39:47]

This optional argument seems dangerous, too. Try to avoid it.

[zra, 2013/09/04 21:00:41]

Done.

   void ReserveAlignedFrameSpace(intptr_t frame_space);
 
   // Create a frame for calling into runtime that preserves all volatile
   // registers.  Frame's RSP is guaranteed to be correctly aligned and
   // frame_space bytes are reserved under it.
   void EnterCallRuntimeFrame(intptr_t frame_space);
   void LeaveCallRuntimeFrame();
 
 
   void CallRuntime(const RuntimeEntry& entry);
@@ skipping 31 matching lines @@
   int prologue_offset() const { return prologue_offset_; }
   const ZoneGrowableArray<int>& GetPointerOffsets() const {
     return buffer_.pointer_offsets();
   }
   const GrowableObjectArray& object_pool() const { return object_pool_; }
 
   void FinalizeInstructions(const MemoryRegion& region) {
     buffer_.FinalizeInstructions(region);
   }
 
+  void LoadPoolPointer(Register pp = PP);
+
   // Set up a Dart frame on entry with a frame pointer and PC information to
   // enable easy access to the RawInstruction object of code corresponding
   // to this frame.
   // The dart frame layout is as follows:
   //   ....
   //   ret PC
   //   saved RBP     <=== RBP
   //   pc (used to derive the RawInstruction Object of the dart code)
+  //   saved PP
   //   locals space  <=== RSP
   //   .....
   // This code sets this up with the sequence:
   //   pushq rbp
   //   movq rbp, rsp
   //   call L
   //   L: <code to adjust saved pc if there is any intrinsification code>
+  //   ...
+  //   pushq r15
   //   .....
-  void EnterDartFrame(intptr_t frame_size);
+  void EnterDartFrame(intptr_t frame_size,
+                      Register new_pp = PP, Register new_pc = kNoRegister);

[Florian Schneider, 2013/09/04 09:39:47]

Again, two optional arguments is not a good idea, especially if there are the
same type!

[zra, 2013/09/04 21:00:41]

Done.

 
   // Set up a Dart frame for a function compiled for on-stack replacement.
   // The frame layout is a normal Dart frame, but the frame is partially set
   // up on entry (it is the frame of the unoptimized code).
-  void EnterOsrFrame(intptr_t extra_size);
+  void EnterOsrFrame(intptr_t extra_size,
+                     Register new_pp = PP, Register new_pc = kNoRegister);

[Florian Schneider, 2013/09/04 09:39:47]

Again, two optional arguments is not a good idea, especially if there are the
same type!

[zra, 2013/09/04 21:00:41]

Done.

 
   // Set up a stub frame so that the stack traversal code can easily identify
   // a stub frame.
   // The stub frame layout is as follows:
   //   ....
   //   ret PC
   //   saved RBP
   //   pc (used to derive the RawInstruction Object of the stub)
   //   .....
   // This code sets this up with the sequence:
   //   pushq rbp
   //   movq rbp, rsp
   //   pushq immediate(0)
   //   .....
-  void EnterStubFrame();
+  void EnterStubFrame(bool save_pp = false);

[Florian Schneider, 2013/09/04 09:39:47]

This optional argument seems dangerous, too. Try to avoid it.

[zra, 2013/09/04 21:00:41]

Done.

 
-  // Instruction pattern from entrypoint is used in dart frame prologs
+  // Instruction pattern from entrypoint is used in dart frame prologues
   // to set up the frame and save a PC which can be used to figure out the
   // RawInstruction object corresponding to the code running in the frame.
   // entrypoint:
   //   pushq rbp          (size is 1 byte)
   //   movq rbp, rsp      (size is 3 bytes)
   //   call L             (size is 5 bytes)
   //   L:
   static const intptr_t kEntryPointToPcMarkerOffset = 9;
 
   // Inlined allocation of an instance of class 'cls', code has no runtime
@@ skipping 12 matching lines @@
   void Unreachable(const char* message);
 
   static void InitializeMemoryWithBreakpoints(uword data, int length);
 
   static const char* RegisterName(Register reg);
 
   static const char* FpuRegisterName(FpuRegister reg);
 
  private:
   AssemblerBuffer buffer_;
-  GrowableObjectArray& object_pool_;  // Object pool is not used on x64.
+  GrowableObjectArray& object_pool_;  // Objects and patchable jump targets.
   int prologue_offset_;
 
   class CodeComment : public ZoneAllocated {
    public:
     CodeComment(intptr_t pc_offset, const String& comment)
         : pc_offset_(pc_offset), comment_(comment) { }
 
     intptr_t pc_offset() const { return pc_offset_; }
     const String& comment() const { return comment_; }
 
@@ skipping 121 matching lines @@
 }
 
 
 inline void Assembler::EmitOperandSizeOverride() {
   EmitUint8(0x66);
 }
 
 }  // namespace dart
 
 #endif  // VM_ASSEMBLER_X64_H_