Archive webkit_tests results on android bots if requested.

Archive webkit_tests results on android bots if requested.

R=ilevy@chromium.org, bulach@chromium.org, peter@chromium.org
BUG=276076
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220166

[Dirk Pranke, 2013-08-20 23:28:38]

Note that archiving is already on in the chromium.webkit bots, so this should
take effect immediately.

Isaac, how would I go about testing this?

[Dirk Pranke, 2013-08-20 23:31:07]

https://codereview.chromium.org/22825016/diff/4001/build/android/buildbot/bb_...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/22825016/diff/4001/build/android/buildbot/bb_...
build/android/buildbot/bb_device_steps.py:236: '--results-dir',
'..layout-test-results',
This path seems really wrong, but it matches line 208, so I'm leaving it as is.
Should I change both of them? Is this actually right?

[bulach, 2013-08-21 09:06:14]

I don't know much about that path, but it does look wrong!! ilevy?

one suggestion below:

https://codereview.chromium.org/22825016/diff/4001/build/android/buildbot/bb_...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/22825016/diff/4001/build/android/buildbot/bb_...
build/android/buildbot/bb_device_steps.py:238: '--build-dir', SrcPath('out'),
please, use build/android/pylib/cmd_helper.py :: OutDirectory.get()

(reason being, there's some efforts to make it possible to build android and
linux in parallel using the same checkout...)

[Isaac (away), 2013-08-21 10:10:14]

That path logs wrong to me too but I suppose it depends on how the webkit script
uses it... Check git blame?

https://codereview.chromium.org/22825016/diff/4001/build/android/buildbot/bb_...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/22825016/diff/4001/build/android/buildbot/bb_...
build/android/buildbot/bb_device_steps.py:238: '--build-dir', SrcPath('out'),
On 2013/08/21 09:06:14, bulach wrote:
> please, use build/android/pylib/cmd_helper.py :: OutDirectory.get()
> 
> (reason being, there's some efforts to make it possible to build android and
> linux in parallel using the same checkout...)

Gosh, I'm not familiar with that.  However, we are moving toward allowing 0
outside imports in this repo.  (diagram: go/zosmd), so I don't think we should
add one.  I would suggest putting this as a constant in bb_utils though.

[Dirk Pranke, 2013-08-28 19:45:47]

https://codereview.chromium.org/22825016/diff/4001/build/android/buildbot/bb_...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/22825016/diff/4001/build/android/buildbot/bb_...
build/android/buildbot/bb_device_steps.py:238: '--build-dir', SrcPath('out'),
Based on further conversation w/ Isaac, I'm going to ignore the
OutDirectory.get() for now but use a constant in bb_utils.py . I'm not quit sure
how OutDirectory.get() is used (or, more importantly, set) and how that's going
to need to change in the impending recipe rewrite.

[Dirk Pranke, 2013-08-28 19:49:28]

Okay, please take another look?

https://codereview.chromium.org/22825016/diff/13001/build/android/buildbot/bb...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/22825016/diff/13001/build/android/buildbot/bb...
build/android/buildbot/bb_device_steps.py:225: '--results-directory',
'../layout-test-results',
Looks like this was a typo introduced in 

https://codereview.chromium.org/11666023

that no one noticed since we weren't running (or archiving) the tests :).

[Isaac (away), 2013-08-28 20:03:50]

lgtm++

https://codereview.chromium.org/22825016/diff/13001/build/android/buildbot/bb...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/22825016/diff/13001/build/android/buildbot/bb...
build/android/buildbot/bb_device_steps.py:225: '--results-directory',
'../layout-test-results',
On 2013/08/28 19:49:29, Dirk Pranke wrote:
> Looks like this was a typo introduced in 
> 
> https://codereview.chromium.org/11666023
> 
> that no one noticed since we weren't running (or archiving) the tests :).

:-) == imsrry

[commit-bot: I haz the power, 2013-08-28 21:01:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpranke@chromium.org/22825016/13001

[commit-bot: I haz the power, 2013-08-29 03:08:34]

Change committed as 220166

[bulach, 2013-09-02 11:04:04]

lgtm, thanks! adding craigdh and linking to his patch, just  FYI on how to solve
the TODO..

https://chromiumcodereview.appspot.com/22825016/diff/13001/build/android/buil...
File build/android/buildbot/bb_utils.py (right):

https://chromiumcodereview.appspot.com/22825016/diff/13001/build/android/buil...
build/android/buildbot/bb_utils.py:27: # TODO: Figure out how to merge this with
pylib.cmd_helper.OutDirectory().
FYI:
https://codereview.chromium.org/22903016/