Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 22825011: Linux: untangle circular dependencies between .gyp files. (Closed)

Created:
7 years, 4 months ago by Paweł Hajdan Jr.
Modified:
7 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: untangle circular dependencies between .gyp files. Not enabling the check yet because ChromeOS still has cycles. BUG=35878 R=mark@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -32 lines) Patch
M build/linux/system.gyp View 9 chunks +12 lines, -13 lines 0 comments Download
M tools/generate_library_loader/generate_library_loader.py View 7 chunks +12 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
7 years, 4 months ago (2013-08-17 00:40:42 UTC) #1
Mark Mentovai
LGTM
7 years, 4 months ago (2013-08-17 04:06:54 UTC) #2
Paweł Hajdan Jr.
7 years, 4 months ago (2013-08-19 22:04:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r218334.

Powered by Google App Engine
This is Rietveld 408576698