gn: Don't do an out-of-bound access if a file ends after 'else'

gn: Don't do an out-of-bound access if a file ends after 'else'

BUG=640857
Committed: https://crrev.com/5aba5ce9d5f3184b1e659c319e962c57274cbe03
Cr-Commit-Position: refs/heads/master@{#414461}

[Nico, 2016-08-25 16:05:58]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 16:06:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-08-25 16:07:48]

thakis@chromium.org changed reviewers:
+ brettw@chromium.org

[Nico, 2016-08-25 16:07:49]

https://codereview.chromium.org/2282493002/diff/1/tools/gn/parser.cc
File tools/gn/parser.cc (right):

https://codereview.chromium.org/2282493002/diff/1/tools/gn/parser.cc#newcode391
tools/gn/parser.cc:391: if (!at_end())
this is unrelated but seems like a good change so that cur_ doesn't overflow :-P

https://codereview.chromium.org/2282493002/diff/1/tools/gn/parser.cc#newcode712
tools/gn/parser.cc:712: Token token = cur_or_last_token();
this is just extract-function

https://codereview.chromium.org/2282493002/diff/1/tools/gn/parser.cc#newcode759
tools/gn/parser.cc:759: *err_ = Err(cur_or_last_token(), "Expected '{' or 'if'
after 'else'.");
this is the fix

[scottmg, 2016-08-25 16:09:29]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2016-08-25 16:09:30]

lgtm

[Nico, 2016-08-25 16:19:23]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2016-08-25 16:19:28]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-08-25 16:19:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 17:16:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-25 17:19:53]

Description was changed from

==========
gn: Don't do an out-of-bound access if a file ends after 'else'

BUG=640857
==========

to

==========
gn: Don't do an out-of-bound access if a file ends after 'else'

BUG=640857

Committed: https://crrev.com/5aba5ce9d5f3184b1e659c319e962c57274cbe03
Cr-Commit-Position: refs/heads/master@{#414461}
==========

[commit-bot: I haz the power, 2016-08-25 17:19:54]

Patchset 1 (id:??) landed as
https://crrev.com/5aba5ce9d5f3184b1e659c319e962c57274cbe03
Cr-Commit-Position: refs/heads/master@{#414461}