Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 22824043: Fix test-log/EquivalenceOfLoggingAndTraversal (Closed)

Created:
7 years, 3 months ago by yurys
Modified:
7 years, 3 months ago
Reviewers:
loislo, Yang, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix test-log/EquivalenceOfLoggingAndTraversal The test has been marked as intermittently failing since 2011 and since that "code-creation" event signature has changed a bit. I updated the parser in the test but that revealed another issue: "code-creation" events with type 'Script' didn't match functions with type 'LazyCompile' retrieved during the heap traversal because the later had name " :1:1" which didn't match the script's name. BUG=v8:2857 R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/log-eq-of-logging-and-traversal.js View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 3 months ago (2013-08-26 09:40:45 UTC) #1
yurys
7 years, 3 months ago (2013-08-26 09:41:03 UTC) #2
Yang
On 2013/08/26 09:41:03, Yury Semikhatsky wrote: lgtm.
7 years, 3 months ago (2013-08-26 13:20:50 UTC) #3
yurys
7 years, 3 months ago (2013-08-26 14:56:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r16331 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698