|
|
DescriptionTurn flag: opt-in-ime-menu on by default, which aims to launch on M54.
BUG=642218
TEST=Verified on local build.
Committed: https://crrev.com/b29d4f1e7e9110dd63646bd6196aac3be81dfa34
Cr-Commit-Position: refs/heads/master@{#415130}
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
The CQ bit was checked by azurewei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Turn flag: opt-in-ime-menu on by default, which aims to launch on M54. BUG=570761 TEST=Verified on local build. ========== to ========== Turn flag: opt-in-ime-menu on by default, which aims to launch on M54. BUG=570761 TEST=Verified on local build. ==========
azurewei@chromium.org changed reviewers: + shuchen@chromium.org
Please review this cl. Thanks!
The CQ bit was checked by azurewei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Description was changed from ========== Turn flag: opt-in-ime-menu on by default, which aims to launch on M54. BUG=570761 TEST=Verified on local build. ========== to ========== Turn flag: opt-in-ime-menu on by default, which aims to launch on M54. BUG=642218 TEST=Verified on local build. ==========
The CQ bit was checked by azurewei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Turn flag: opt-in-ime-menu on by default, which aims to launch on M54. BUG=642218 TEST=Verified on local build. ========== to ========== Turn flag: opt-in-ime-menu on by default, which aims to launch on M54. BUG=642218 TEST=Verified on local build. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Turn flag: opt-in-ime-menu on by default, which aims to launch on M54. BUG=642218 TEST=Verified on local build. ========== to ========== Turn flag: opt-in-ime-menu on by default, which aims to launch on M54. BUG=642218 TEST=Verified on local build. Committed: https://crrev.com/b29d4f1e7e9110dd63646bd6196aac3be81dfa34 Cr-Commit-Position: refs/heads/master@{#415130} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b29d4f1e7e9110dd63646bd6196aac3be81dfa34 Cr-Commit-Position: refs/heads/master@{#415130} |