Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2282403003: Fix build with system ICU (Closed)

Created:
4 years, 3 months ago by Paweł Hajdan Jr.
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build with system ICU BUG=551343 Committed: https://crrev.com/860564e6051956a73b673d4adae2c4a0df0b175b Cr-Commit-Position: refs/heads/master@{#415252}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -7 lines) Patch
A build/linux/unbundle/icu.gn View 1 chunk +232 lines, -0 lines 0 comments Download
M build/linux/unbundle/replace_gn_files.py View 1 chunk +1 line, -0 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_worditerator.cc View 5 chunks +5 lines, -7 lines 2 comments Download

Messages

Total messages: 16 (8 generated)
Paweł Hajdan Jr.
4 years, 3 months ago (2016-08-29 11:26:14 UTC) #6
Paweł Hajdan Jr.
+groby,rouslan
4 years, 3 months ago (2016-08-29 15:46:09 UTC) #8
please use gerrit instead
lgtm
4 years, 3 months ago (2016-08-29 17:18:32 UTC) #9
groby-ooo-7-16
LGTM, nit optional https://codereview.chromium.org/2282403003/diff/1/components/spellcheck/renderer/spellcheck_worditerator.cc File components/spellcheck/renderer/spellcheck_worditerator.cc (right): https://codereview.chromium.org/2282403003/diff/1/components/spellcheck/renderer/spellcheck_worditerator.cc#newcode333 components/spellcheck/renderer/spellcheck_worditerator.cc:333: std::unique_ptr<base::i18n::BreakIterator> iterator( Tiny nit: While you're ...
4 years, 3 months ago (2016-08-29 17:37:13 UTC) #10
Paweł Hajdan Jr.
https://codereview.chromium.org/2282403003/diff/1/components/spellcheck/renderer/spellcheck_worditerator.cc File components/spellcheck/renderer/spellcheck_worditerator.cc (right): https://codereview.chromium.org/2282403003/diff/1/components/spellcheck/renderer/spellcheck_worditerator.cc#newcode333 components/spellcheck/renderer/spellcheck_worditerator.cc:333: std::unique_ptr<base::i18n::BreakIterator> iterator( On 2016/08/29 at 17:37:12, groby wrote: > ...
4 years, 3 months ago (2016-08-30 08:29:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282403003/1
4 years, 3 months ago (2016-08-30 08:29:45 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 09:13:45 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 09:15:04 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/860564e6051956a73b673d4adae2c4a0df0b175b
Cr-Commit-Position: refs/heads/master@{#415252}

Powered by Google App Engine
This is Rietveld 408576698