Remove StreamTextureManager

ui/gl/gl_image.h

Index: ui/gl/gl_image.h
diff --git a/ui/gl/gl_image.h b/ui/gl/gl_image.h
index f1d05371f6beeae8de923774023a8e8978b05dac..660721edc99d1d36ceee3161a0b793fc9f6062ef 100644
--- a/ui/gl/gl_image.h
+++ b/ui/gl/gl_image.h
@@ -15,6 +15,10 @@ namespace gfx {
 
 class GLSurface;
 
+#if defined(OS_ANDROID)
+class GLImageStream;
+#endif
+
 // Encapsulates an image that can be bound to a texture, hiding platform
 // specific management.
 class GL_EXPORT GLImage : public base::RefCounted<GLImage> {
@@ -36,10 +40,21 @@ class GL_EXPORT GLImage : public base::RefCounted<GLImage> {
   // Create a GL image for a window.
   static scoped_refptr<GLImage> CreateGLImage(gfx::PluginWindowHandle window);
 
+  // Updates the texture. Only used for multi-buffered/streaming textures.
+  virtual void UpdateTexImage();

[reveman, 2013/08/13 00:48:13]

Lets make this part of the core API and define it as something that is useful to
all types of GLImages.

For 0-copy we currently call BindTex/ReleaseTex before/after each use of an
image. This makes it hard to avoid unnecessary cache flushes and implement an
efficient buffered version (ie. GLImageShm). I'd like to change this and only
have the client call BindTexImage/ReleaseTexImage when contents have changed. To
do that we need new API that allows GLImageEGL to do what it currently does in
ReleaseTexImage after each use of the texture. I was planning to add a pair of
functions that would be called before/after an image bound to a texture is used
on the service side. Something like:

virtual void WillUseTexImage();
virtual void DidUseTexImage();

You could do what you currently do in UpdateTexImage() for stream images in
WillUseTexImage() instead. Wdyt?

[no sievers, 2013/08/14 04:01:23]

Done. I *might* have a usage case for the client needing to explicitly update it
for stream textures though. But let's not worry about it now.

+
   // Create a GL image for a GPU Memory buffer.
   static scoped_refptr<GLImage> CreateGLImageForGpuMemoryBuffer(
       gfx::GpuMemoryBufferHandle buffer, gfx::Size size);
 
+  // Create a GL image for a streaming texture.
+  static scoped_refptr<GLImage> CreateGLImageForStreamTexture(
+      unsigned int texture_id);

[reveman, 2013/08/13 00:48:13]

hm, texture_id. Could this instead take some new version of SurfaceTextureBridge
that instead creates the texture id binding as a result of calling BindTexImage?

[no sievers, 2013/08/14 04:01:23]

As discussed per chat leaving this for later. 
(One option to support this without SurfaceTexture.AttachToGLContext, which is
only available in JellyBean and up, is to allow a GLimage to override the
service_id of a texture.)

+
+#if defined(OS_ANDROID)
+  virtual GLImageStream* AsGLImageStream() { return NULL; }

[reveman, 2013/08/13 00:48:13]

what do we have to do to remove this?

[no sievers, 2013/08/14 04:01:23]

I have ideas of how to GL-ify the stuff that happens in gpu_channel.cc (which is
the only place that needs it to map to the current behavior).

SetSize and the matrix callback will ideally go away from GLImageStream. That
leaves a frame available callback that can maybe be exposed in the base class
here?

+#endif
+
  protected:
   virtual ~GLImage();