Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22824008: Add DiskInfo struct and functions. (Closed)

Created:
7 years, 4 months ago by jwmak
Modified:
7 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@moveswapdata
Visibility:
Public.

Description

Add the DiskInfo struct and associated functions to collect and hold system disk metrics. BUG=236763 TEST=base_unitttests SystemMetricsTest.* R=darin@chromium.org, nduca@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220684

Patch Set 1 #

Patch Set 2 : rebase onto prev patch #

Patch Set 3 : use ctype functions #

Patch Set 4 : added unittests #

Patch Set 5 : rebase and include order #

Patch Set 6 : correct namespace #

Patch Set 7 : correct endif #

Patch Set 8 : cleanup #

Patch Set 9 : missing ifdef #

Patch Set 10 : rebase on prev patch #

Patch Set 11 : remove unused include #

Total comments: 2

Patch Set 12 : changed function name to IsValidDiskName #

Patch Set 13 : fix rebase #

Patch Set 14 : removing unneeded rate stats #

Patch Set 15 : rebase #

Patch Set 16 : rebase again #

Patch Set 17 : renamed unit test file, using #ifdef OS_LINUX #

Patch Set 18 : updated base.gyp #

Patch Set 19 : fixed android ifdefs #

Patch Set 20 : assume android has diskstats #

Patch Set 21 : fixed namespace for diskinfo readfiletostring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -0 lines) Patch
M base/base.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -0 lines 0 comments Download
M base/process/process_metrics.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 19 3 chunks +29 lines, -0 lines 0 comments Download
M base/process/process_metrics_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +169 lines, -0 lines 0 comments Download
A base/process/process_metrics_unittests.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nduca
lgtm
7 years, 4 months ago (2013-08-13 20:08:39 UTC) #1
jwmak
7 years, 4 months ago (2013-08-23 23:41:53 UTC) #2
darin (slow to review)
https://codereview.chromium.org/22824008/diff/26001/base/process/process_metrics.h File base/process/process_metrics.h (right): https://codereview.chromium.org/22824008/diff/26001/base/process/process_metrics.h#newcode288 base/process/process_metrics.h:288: BASE_EXPORT bool ValidDiskName(const std::string& candidate); nit: this needs a ...
7 years, 4 months ago (2013-08-24 05:49:05 UTC) #3
jwmak
https://codereview.chromium.org/22824008/diff/26001/base/process/process_metrics.h File base/process/process_metrics.h (right): https://codereview.chromium.org/22824008/diff/26001/base/process/process_metrics.h#newcode288 base/process/process_metrics.h:288: BASE_EXPORT bool ValidDiskName(const std::string& candidate); On 2013/08/24 05:49:05, darin ...
7 years, 4 months ago (2013-08-26 07:47:24 UTC) #4
darin (slow to review)
LGTM
7 years, 3 months ago (2013-08-26 18:05:37 UTC) #5
nduca
7 years, 3 months ago (2013-08-30 22:59:19 UTC) #6
Message was sent while issue was closed. 
Committed patchset #21 manually as r220684.

Powered by Google App Engine
This is Rietveld 408576698