Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: net/socket/tcp_server_socket_win.cc

Issue 22824005: On Windows, the return value of socket() should be compared with (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/tcp_server_socket_win.cc
===================================================================
--- net/socket/tcp_server_socket_win.cc (revision 215189)
+++ net/socket/tcp_server_socket_win.cc (working copy)
@@ -45,7 +45,7 @@
}
socket_ = socket(address.GetSockAddrFamily(), SOCK_STREAM, IPPROTO_TCP);
- if (socket_ < 0) {
+ if (socket_ == INVALID_SOCKET) {
wtc 2013/08/12 17:31:30 See the "Return value" section and example code in
PLOG(ERROR) << "socket() returned an error";
return MapSystemError(WSAGetLastError());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698