Add support for parsing, but not capturing, assers in constructor initializer lists

Add support for parsing, but not capturing, assers in constructor initializer lists

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/4a75d78325f347d36f5166e68b87f8af63b8196a

[Brian Wilkerson, 2016-08-26 23:19:05]

brianwilkerson@google.com changed reviewers:
+ lrn@google.com, scheglov@google.com

[Brian Wilkerson, 2016-08-26 23:19:06]

Does this need to be behind a flag?

[scheglov, 2016-08-27 00:06:45]

LGTM

https://codereview.chromium.org/2282233002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/parser.dart (right):

https://codereview.chromium.org/2282233002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/parser.dart:4358: // return AssertInitializer
I don't quite understand what this comment means.
Should it be TODO?

[Brian Wilkerson, 2016-08-27 00:32:44]

https://codereview.chromium.org/2282233002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/parser.dart (right):

https://codereview.chromium.org/2282233002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/parser.dart:4358: // return AssertInitializer
Done

It was a reminder to "Capture the syntax in the AST"

[Lasse Reichstein Nielsen, 2016-08-27 11:23:28]

Put it behind a flag for now. I believe the flag used in the VM is
--initializer-assert.

[Brian Wilkerson, 2016-08-28 22:20:28]

PTAL. I added a flag. It is currently only exposed via the analysis options file
(where for consistency it is named 'enableAssertInitializer'. If there is a need
for the flag to be added to the command-line analyzer that can be done as a
separate CL.

[scheglov, 2016-08-28 22:57:45]

LGTM

[Lasse Reichstein Nielsen, 2016-08-29 05:48:01]

And for the record, I think you will have to capture the syntax as well, even if
you don't analyze it. I believe the formatter is based on the analyzer parser,
and it needs to not discard the asserts.

[Brian Wilkerson, 2016-08-29 14:56:52]

> I think you will have to capture the syntax as well ...

Yes, we will, but that is a breaking change to the analyzer's API and I would
like to coordinate the breaking changes as much as possible. I was under the
impression that being able to parse the asserts, even without capturing them,
would allow you to make progress. If that's not sufficient, let me know.

[Brian Wilkerson, 2016-08-29 14:58:50]

Description was changed from

==========
Add support for parsing, but not capturing, assers in constructor initializer
lists
==========

to

==========
Add support for parsing, but not capturing, assers in constructor initializer
lists

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4a75d78325f347d36f5166e68b87f8af63b8196a
==========

[Brian Wilkerson, 2016-08-29 14:58:51]

Committed patchset #2 (id:20001) manually as
4a75d78325f347d36f5166e68b87f8af63b8196a (presubmit successful).