Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2282223002: Delete roll-dep-svn (Closed)

Created:
4 years, 3 months ago by agable
Modified:
4 years, 3 months ago
Reviewers:
dnj
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -435 lines) Patch
D roll-dep-svn View 1 chunk +0 lines, -8 lines 0 comments Download
D roll-dep-svn.bat View 1 chunk +0 lines, -10 lines 0 comments Download
D roll_dep_svn.py View 1 chunk +0 lines, -417 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
agable
4 years, 3 months ago (2016-08-26 22:59:43 UTC) #1
dnj
lgtm, this definitely does what the description says it does.
4 years, 3 months ago (2016-08-26 23:42:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282223002/1
4 years, 3 months ago (2016-08-29 16:15:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/96ebc1d0e100021990312072e6eda6b8a0a81ee5
4 years, 3 months ago (2016-08-29 16:24:26 UTC) #6
Michael Achenbach
4 years, 3 months ago (2016-08-30 07:43:00 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2297513002/ by machenbach@chromium.org.

The reason for reverting is: Still in use. Breaks the v8 auto-rollers.

https://cs.chromium.org/search/?q=roll-dep-svn&sq=package:chromium&type=cs.

Powered by Google App Engine
This is Rietveld 408576698