Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 22822002: Do not materialize uninitialized const for debug evaluate. (Closed)

Created:
7 years, 4 months ago by Yang
Modified:
7 years, 4 months ago
Reviewers:
Peter.Rybin
CC:
v8-dev
Visibility:
Public.

Description

Do not materialize uninitialized const for debug evaluate. R=prybin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16148

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -2 lines) Patch
M src/runtime.cc View 1 4 chunks +7 lines, -1 line 0 comments Download
A test/mjsunit/debug-evaluate-const.js View 1 chunk +121 lines, -0 lines 0 comments Download
M test/mjsunit/debug-evaluate-locals.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Please take a look. I ended up opting for the easy fix since the better ...
7 years, 4 months ago (2013-08-12 11:22:46 UTC) #1
Peter.Rybin
LGTM with comment You check for the hole in both locals and params, but for ...
7 years, 4 months ago (2013-08-12 11:43:25 UTC) #2
Yang
On 2013/08/12 11:43:25, Peter.Rybin wrote: > LGTM with comment > > You check for the ...
7 years, 4 months ago (2013-08-12 13:34:36 UTC) #3
Yang
7 years, 4 months ago (2013-08-12 13:35:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r16148.

Powered by Google App Engine
This is Rietveld 408576698