Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: net/cert/internal/verify_certificate_chain_typed_unittest.h

Issue 2282183004: Add error information to VerifyCertificateChain(). (Closed)
Patch Set: fix typo in README Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/internal/verify_certificate_chain_typed_unittest.h
diff --git a/net/cert/internal/verify_certificate_chain_typed_unittest.h b/net/cert/internal/verify_certificate_chain_typed_unittest.h
index 1e9686a3f7dfb1ba06cea6d0ee24f1dfb0d09f6a..4e699c3546a3de358447b03345badbf4843a1e90 100644
--- a/net/cert/internal/verify_certificate_chain_typed_unittest.h
+++ b/net/cert/internal/verify_certificate_chain_typed_unittest.h
@@ -25,11 +25,13 @@ class VerifyCertificateChainTest : public ::testing::Test {
scoped_refptr<TrustAnchor> trust_anchor;
der::GeneralizedTime time;
bool expected_result;
+ std::string expected_errors;
ReadVerifyCertChainTestFromFile(file_name, &chain, &trust_anchor, &time,
- &expected_result);
+ &expected_result, &expected_errors);
- TestDelegate::Verify(chain, trust_anchor, time, expected_result);
+ TestDelegate::Verify(chain, trust_anchor, time, expected_result,
+ expected_errors);
}
};
@@ -184,8 +186,8 @@ TYPED_TEST_P(VerifyCertificateChainSingleRootTest, KeyRolloverNewChain) {
this->RunTest("key-rollover-newchain.pem");
}
-TYPED_TEST_P(VerifyCertificateChainSingleRootTest, UnknownRoot) {
- this->RunTest("unknown-root.pem");
+TYPED_TEST_P(VerifyCertificateChainSingleRootTest, IncorrectTrustAnchor) {
+ this->RunTest("incorrect-trust-anchor.pem");
}
TYPED_TEST_P(VerifyCertificateChainSingleRootTest,
@@ -254,7 +256,7 @@ REGISTER_TYPED_TEST_CASE_P(VerifyCertificateChainSingleRootTest,
KeyRolloverRolloverChain,
KeyRolloverLongRolloverChain,
KeyRolloverNewChain,
- UnknownRoot,
+ IncorrectTrustAnchor,
UnconstrainedRootLacksBasicConstraints,
ConstrainedRootLacksBasicConstraints,
UnconstrainedRootBasicConstraintsCaFalse,
« no previous file with comments | « net/cert/internal/verify_certificate_chain_pkits_unittest.cc ('k') | net/cert/internal/verify_certificate_chain_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698