Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1712)

Unified Diff: net/cert/internal/path_builder_unittest.cc

Issue 2282183004: Add error information to VerifyCertificateChain(). (Closed)
Patch Set: fix typo in README Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/internal/path_builder_unittest.cc
diff --git a/net/cert/internal/path_builder_unittest.cc b/net/cert/internal/path_builder_unittest.cc
index 432ea5274252a5fb661906c980985c580367c464..f360e07e3a490eab3a14f77d854325578bbb7674 100644
--- a/net/cert/internal/path_builder_unittest.cc
+++ b/net/cert/internal/path_builder_unittest.cc
@@ -495,10 +495,12 @@ class PathBuilderKeyRolloverTest : public ::testing::Test {
void SetUp() override {
ParsedCertificateList path;
- bool unused;
+ bool unused_result;
+ std::string unused_errors;
ReadVerifyCertChainTestFromFile("key-rollover-oldchain.pem", &path,
- &oldroot_, &time_, &unused);
+ &oldroot_, &time_, &unused_result,
+ &unused_errors);
ASSERT_EQ(2U, path.size());
target_ = path[0];
oldintermediate_ = path[1];
@@ -506,7 +508,8 @@ class PathBuilderKeyRolloverTest : public ::testing::Test {
ASSERT_TRUE(oldintermediate_);
ReadVerifyCertChainTestFromFile("key-rollover-longrolloverchain.pem", &path,
- &oldroot_, &time_, &unused);
+ &oldroot_, &time_, &unused_result,
+ &unused_errors);
ASSERT_EQ(4U, path.size());
newintermediate_ = path[1];
newroot_ = path[2];
« no previous file with comments | « net/cert/internal/path_builder.cc ('k') | net/cert/internal/path_builder_verify_certificate_chain_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698