net/data/verify_certificate_chain_unittest/generate-target-signed-by-512bit-rsa.py - Issue 2282183004: Add error information to VerifyCertificateChain().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/verify_certificate_chain_unittest/generate-target-signed-by-512bit-rsa.py

Issue 2282183004: Add error information to VerifyCertificateChain(). (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/cert/internal/verify_certificate_chain.cc ('K') | « net/data/verify_certificate_chain_unittest/generate-target-has-pathlen-but-not-ca.py ('k') | net/data/verify_certificate_chain_unittest/generate-target-unknown-critical-extension.py » ('j') | net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca.pem » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/verify_certificate_chain_unittest/generate-target-signed-by-512bit-rsa.py

diff --git a/net/data/verify_certificate_chain_unittest/generate-target-signed-by-512bit-rsa.py b/net/data/verify_certificate_chain_unittest/generate-target-signed-by-512bit-rsa.py

index cd580d2d8b654090d305c925f92ca74ed6b040fc..6de5c0bc3d8ddb55aee93acab1b8284e4b53fe5a 100755

--- a/net/data/verify_certificate_chain_unittest/generate-target-signed-by-512bit-rsa.py

+++ b/net/data/verify_certificate_chain_unittest/generate-target-signed-by-512bit-rsa.py

@@ -23,5 +23,7 @@ chain = [target, intermediate]

trusted = common.TrustAnchor(root, constrained=False)

time = common.DEFAULT_TIME

verify_result = False

+errors = ['Signature verification failed']

mattm 2016/08/29 22:15:11 I assume we would update signature verification to

eroman 2016/08/29 22:55:18 Yes correct. Follow-ups will probably involve:

-common.write_test_file(__doc__, chain, trusted, time, verify_result)

+common.write_test_file(__doc__, chain, trusted, time, verify_result,

+ errors)