net/cert/internal/path_builder_verify_certificate_chain_unittest.cc - Issue 2282183004: Add error information to VerifyCertificateChain().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/path_builder_verify_certificate_chain_unittest.cc

Issue 2282183004: Add error information to VerifyCertificateChain(). (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/cert/internal/path_builder.cc ('K') | « net/cert/internal/path_builder_unittest.cc ('k') | net/cert/internal/test_helpers.h » ('j') | net/cert/internal/verify_certificate_chain.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/cert/internal/path_builder_verify_certificate_chain_unittest.cc

diff --git a/net/cert/internal/path_builder_verify_certificate_chain_unittest.cc b/net/cert/internal/path_builder_verify_certificate_chain_unittest.cc

index dc7b23d064c81bc15fc6576a8997ba22839097b1..947b4cab288ab30d11641e81755e156416eaf08b 100644

--- a/net/cert/internal/path_builder_verify_certificate_chain_unittest.cc

+++ b/net/cert/internal/path_builder_verify_certificate_chain_unittest.cc

@@ -18,7 +18,8 @@ class PathBuilderDelegate {

static void Verify(const ParsedCertificateList& chain,

const scoped_refptr<TrustAnchor>& trust_anchor,

const der::GeneralizedTime& time,

- bool expected_result) {

+ bool expected_result,

+ const std::string& expected_errors) {

SimpleSignaturePolicy signature_policy(1024);

ASSERT_FALSE(chain.empty());

« net/cert/internal/path_builder.cc ('K') | « net/cert/internal/path_builder_unittest.cc ('k') | net/cert/internal/test_helpers.h » ('j') | net/cert/internal/verify_certificate_chain.cc » ('J')