net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca.pem - Issue 2282183004: Add error information to VerifyCertificateChain().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca.pem

Issue 2282183004: Add error information to VerifyCertificateChain(). (Closed)

Patch Set: fix typo in README Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem ('k') | net/data/verify_certificate_chain_unittest/target-not-end-entity.pem » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [Created by: generate-target-has-pathlen-but-not-ca.py]	1 [Created by: generate-target-has-pathlen-but-not-ca.py]

2	2

3 Certificate chain with 1 intermediate, a trusted root, and a target	3 Certificate chain with 1 intermediate, a trusted root, and a target

4 certificate that is not a CA, and yet has a pathlen set. Verification is	4 certificate that is not a CA, and yet has a pathlen set. Verification is

5 expected to fail, since pathlen should only be set for CAs.	5 expected to fail, since pathlen should only be set for CAs.

6	6

7 Certificate:	7 Certificate:

8 Data:	8 Data:

9 Version: 3 (0x2)	9 Version: 3 (0x2)

10 Serial Number: 1 (0x1)	10 Serial Number: 1 (0x1)

(...skipping 256 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
267 IzAhoB+gHYYbaHR0cDovL3VybC1mb3ItY3JsL1Jvb3QuY3JsMA4GA1UdDwEB/wQE	267 IzAhoB+gHYYbaHR0cDovL3VybC1mb3ItY3JsL1Jvb3QuY3JsMA4GA1UdDwEB/wQE

268 AwIBBjAPBgNVHRMBAf8EBTADAQH/MA0GCSqGSIb3DQEBCwUAA4IBAQA78s0D79lh	268 AwIBBjAPBgNVHRMBAf8EBTADAQH/MA0GCSqGSIb3DQEBCwUAA4IBAQA78s0D79lh

269 Z+p73emIEweNlFFiu1bWwb6K0KCB/h2QbYWULKwz+132yXRye/dauOS23TC7kzt0	269 Z+p73emIEweNlFFiu1bWwb6K0KCB/h2QbYWULKwz+132yXRye/dauOS23TC7kzt0

270 Iun+6Vyyi9ShIQzmPO6Grp6K/Yi7p/0gu5z/1MpvZmAZFNHR8tbzsljITRUw4eD8	270 Iun+6Vyyi9ShIQzmPO6Grp6K/Yi7p/0gu5z/1MpvZmAZFNHR8tbzsljITRUw4eD8

271 QK1VJbqNJWgmxGRofpTm9JZaxOa6hVuyMtGCMov0P29O1d4u1wk8H36TOiLY70BB	271 QK1VJbqNJWgmxGRofpTm9JZaxOa6hVuyMtGCMov0P29O1d4u1wk8H36TOiLY70BB

272 RyiAA3cN+VEoKLZTJGb3O1ZsU1hVskl8xBo9oTcpGYqamYR/Y6whhfUCWlocfAqL	272 RyiAA3cN+VEoKLZTJGb3O1ZsU1hVskl8xBo9oTcpGYqamYR/Y6whhfUCWlocfAqL

273 vIP/gFcuzmLFeVgkEuivpGzOqJIrJcTjtif31d3m+syRbFle9aTiTwsY+k6ciGYg	273 vIP/gFcuzmLFeVgkEuivpGzOqJIrJcTjtif31d3m+syRbFle9aTiTwsY+k6ciGYg

274 Ja+HFAEnCIlq	274 Ja+HFAEnCIlq

275 -----END TRUST_ANCHOR_UNCONSTRAINED-----	275 -----END TRUST_ANCHOR_UNCONSTRAINED-----

276	276

	277 150302120000Z

277 -----BEGIN TIME-----	278 -----BEGIN TIME-----

278 MTUwMzAyMTIwMDAwWg==	279 MTUwMzAyMTIwMDAwWg==

279 -----END TIME-----	280 -----END TIME-----

280	281

	282 FAIL

281 -----BEGIN VERIFY_RESULT-----	283 -----BEGIN VERIFY_RESULT-----

282 RkFJTA==	284 RkFJTA==

283 -----END VERIFY_RESULT-----	285 -----END VERIFY_RESULT-----

	286

	287 Target certificate looks like a CA but does not set all CA properties

	288 -----BEGIN ERRORS-----

	289 VGFyZ2V0IGNlcnRpZmljYXRlIGxvb2tzIGxpa2UgYSBDQSBidXQgZG9lcyBub3Qgc2V0IGFsbCBDQSBw cm9wZXJ0aWVz

	290 -----END ERRORS-----

OLD	NEW