net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem - Issue 2282183004: Add error information to VerifyCertificateChain().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem

Issue 2282183004: Add error information to VerifyCertificateChain(). (Closed)

Patch Set: fix typo in README Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/target-and-intermediate.pem ('k') | net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca.pem » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [Created by: generate-target-has-keycertsign-but-not-ca.py]	1 [Created by: generate-target-has-keycertsign-but-not-ca.py]

2	2

3 Certificate chain with 1 intermediate, a trusted root, and a target	3 Certificate chain with 1 intermediate, a trusted root, and a target

4 certificate that is not a CA, and yet has the keyCertSign bit set. Verification	4 certificate that is not a CA, and yet has the keyCertSign bit set. Verification

5 is expected to fail, since keyCertSign should only be asserted when CA is	5 is expected to fail, since keyCertSign should only be asserted when CA is

6 true.	6 true.

7	7

8 Certificate:	8 Certificate:

9 Data:	9 Data:

10 Version: 3 (0x2)	10 Version: 3 (0x2)

(...skipping 255 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
266 IzAhoB+gHYYbaHR0cDovL3VybC1mb3ItY3JsL1Jvb3QuY3JsMA4GA1UdDwEB/wQE	266 IzAhoB+gHYYbaHR0cDovL3VybC1mb3ItY3JsL1Jvb3QuY3JsMA4GA1UdDwEB/wQE

267 AwIBBjAPBgNVHRMBAf8EBTADAQH/MA0GCSqGSIb3DQEBCwUAA4IBAQBQX7Ay7EGF	267 AwIBBjAPBgNVHRMBAf8EBTADAQH/MA0GCSqGSIb3DQEBCwUAA4IBAQBQX7Ay7EGF

268 PXX/jQUXviCYgdpIORcgJKcxz2M1kCkm0GAp4Wj+Nf1sYcA6zQiSm8ytc9TdpVEO	268 PXX/jQUXviCYgdpIORcgJKcxz2M1kCkm0GAp4Wj+Nf1sYcA6zQiSm8ytc9TdpVEO

269 qWUEfRZ3i7i0nfvEekqrip7QcEdFdKRXq8LNs8VEa347eI9bf/D3w+8kokD+xnHN	269 qWUEfRZ3i7i0nfvEekqrip7QcEdFdKRXq8LNs8VEa347eI9bf/D3w+8kokD+xnHN

270 qKasYyJXOfWYw5F5v0dqC8axYcY1GxwQzOe8IIP2SCZKgEfgIvoEH7AGnFT6RkWb	270 qKasYyJXOfWYw5F5v0dqC8axYcY1GxwQzOe8IIP2SCZKgEfgIvoEH7AGnFT6RkWb

271 1SCi8O6+taKDkoZd9UD1MtCFNeuvXZsEXSGzNZDoXwpskIXrhjHkiYHGqnNNHj6v	271 1SCi8O6+taKDkoZd9UD1MtCFNeuvXZsEXSGzNZDoXwpskIXrhjHkiYHGqnNNHj6v

272 QAfxOK4wqy2qbS+yHf/YGC7z0HSO/20klzDLtuVvy2vCJ16l8WPA2Q3FCH+GjEfE	272 QAfxOK4wqy2qbS+yHf/YGC7z0HSO/20klzDLtuVvy2vCJ16l8WPA2Q3FCH+GjEfE

273 m8vi2doXUVsS	273 m8vi2doXUVsS

274 -----END TRUST_ANCHOR_UNCONSTRAINED-----	274 -----END TRUST_ANCHOR_UNCONSTRAINED-----

275	275

	276 150302120000Z

276 -----BEGIN TIME-----	277 -----BEGIN TIME-----

277 MTUwMzAyMTIwMDAwWg==	278 MTUwMzAyMTIwMDAwWg==

278 -----END TIME-----	279 -----END TIME-----

279	280

	281 FAIL

280 -----BEGIN VERIFY_RESULT-----	282 -----BEGIN VERIFY_RESULT-----

281 RkFJTA==	283 RkFJTA==

282 -----END VERIFY_RESULT-----	284 -----END VERIFY_RESULT-----

	285

	286 Target certificate looks like a CA but does not set all CA properties

	287 -----BEGIN ERRORS-----

	288 VGFyZ2V0IGNlcnRpZmljYXRlIGxvb2tzIGxpa2UgYSBDQSBidXQgZG9lcyBub3Qgc2V0IGFsbCBDQSBw cm9wZXJ0aWVz

	289 -----END ERRORS-----

OLD	NEW