net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca.pem - Issue 2282183004: Add error information to VerifyCertificateChain().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca.pem

Issue 2282183004: Add error information to VerifyCertificateChain(). (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« net/data/verify_certificate_chain_unittest/generate-target-signed-by-512bit-rsa.py ('K') | « net/data/verify_certificate_chain_unittest/generate-violates-pathlen-1-unconstrained-root.py ('k') | net/data/verify_certificate_chain_unittest/target-signed-by-512bit-rsa.pem » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [Created by: generate-target-has-pathlen-but-not-ca.py]	1 [Created by: generate-target-has-pathlen-but-not-ca.py]

2	2

3 Certificate chain with 1 intermediate, a trusted root, and a target	3 Certificate chain with 1 intermediate, a trusted root, and a target

4 certificate that is not a CA, and yet has a pathlen set. Verification is	4 certificate that is not a CA, and yet has a pathlen set. Verification is

5 expected to fail, since pathlen should only be set for CAs.	5 expected to fail, since pathlen should only be set for CAs.

6	6

7 Certificate:	7 Certificate:

8 Data:	8 Data:

9 Version: 3 (0x2)	9 Version: 3 (0x2)

10 Serial Number: 1 (0x1)	10 Serial Number: 1 (0x1)

(...skipping 263 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
274 Ja+HFAEnCIlq	274 Ja+HFAEnCIlq

275 -----END TRUST_ANCHOR_UNCONSTRAINED-----	275 -----END TRUST_ANCHOR_UNCONSTRAINED-----

276	276

277 -----BEGIN TIME-----	277 -----BEGIN TIME-----

278 MTUwMzAyMTIwMDAwWg==	278 MTUwMzAyMTIwMDAwWg==

279 -----END TIME-----	279 -----END TIME-----

280	280

281 -----BEGIN VERIFY_RESULT-----	281 -----BEGIN VERIFY_RESULT-----

282 RkFJTA==	282 RkFJTA==

283 -----END VERIFY_RESULT-----	283 -----END VERIFY_RESULT-----

	284

	285 -----BEGIN ERRORS-----
	mattm 2016/08/29 22:15:11 Include text version as a comment above the pem da Include text version as a comment above the pem data? (would be nice for the other block types too) eroman 2016/08/29 22:55:18 Will do. Show quoted text On 2016/08/29 22:15:11, mattm wrote: > Include text version as a comment above the pem data? (would be nice for the > other block types too) Will do. eroman 2016/08/29 23:14:55 Added text label in latest patchset, for TIME, VER Show quoted text On 2016/08/29 22:55:18, eroman wrote: > On 2016/08/29 22:15:11, mattm wrote: > > Include text version as a comment above the pem data? (would be nice for the > > other block types too) > > Will do. Added text label in latest patchset, for TIME, VERIFY_RESULT, and ERRORS. (Still in the process of updating all the ERRORS).
	286 VGFyZ2V0IGNlcnRpZmljYXRlIGxvb2tzIGxpa2UgYSBDQSBidXQgZG9lcyBub3Qgc2V0IGFsbCBDQSBw cm9wZXJ0aWVz

	287 -----END ERRORS-----

OLD	NEW