Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: chrome/browser/android/cookies/cookies_fetcher.h

Issue 2282153002: android: Remove CleanupReference from CookiesFetcher (Closed)
Patch Set: fix double delete Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/cookies/cookies_fetcher.h
diff --git a/chrome/browser/android/cookies/cookies_fetcher.h b/chrome/browser/android/cookies/cookies_fetcher.h
index acd830ee26dbf5e59c18ba79f5c80a1ac127bc78..f942bb17958e0d1cf04e128132a0ba86c78c55c8 100644
--- a/chrome/browser/android/cookies/cookies_fetcher.h
+++ b/chrome/browser/android/cookies/cookies_fetcher.h
@@ -27,12 +27,6 @@ class CookiesFetcher {
~CookiesFetcher();
- // Called by the Java object when it is getting GC'd.
- void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
-
- // Callback used after the cookie jar populate the cookie list for us.
- void OnCookiesFetchFinished(const net::CookieList& cookies);
-
// Fetches all cookies from the cookie jar.
void PersistCookies(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj);
@@ -40,6 +34,9 @@ class CookiesFetcher {
private:
void PersistCookiesInternal(net::URLRequestContextGetter* getter);
+ // Callback used after the cookie jar populate the cookie list for us.
+ void OnCookiesFetchFinished(const net::CookieList& cookies);
+
base::android::ScopedJavaGlobalRef<jobject> jobject_;
DISALLOW_COPY_AND_ASSIGN(CookiesFetcher);

Powered by Google App Engine
This is Rietveld 408576698