Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2282143002:
[install_static] GetCollectStatsConsentImpl() not returning true early (Closed)
|
Created:
4 years, 3 months ago by penny Modified:
4 years, 3 months ago Reviewers:
robertshield CC:
chromium-reviews, scottmg, jwd Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[install_static] GetCollectStatsConsentImpl() not returning true early
...when reporting policy enforced.
R=robertshield@chromium.org
BUG=641540
Committed: https://crrev.com/cacf882777a38c292f82e5b90229bb0b24c9746f
Cr-Commit-Position: refs/heads/master@{#415185}
Patch Set 1 #Patch Set 2 : Update with latest trunk. #
Messages
Total messages: 18 (11 generated)
Description was changed from ========== [install_static] GetCollectStatsConsentImpl() not returning true early ...when reporting policy enforced. R=robertshield@chromium.org BUG=641540 ========== to ========== [install_static] GetCollectStatsConsentImpl() not returning true early ...when reporting policy enforced. R=robertshield@chromium.org BUG=641540 ==========
Hello Robert, Super quick and small review needed for install_static. A sneaky, subtle bug found in one of my CLs. Many thanks!
The CQ bit was checked by pennymac@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
good catch, lgtm
The CQ bit was checked by pennymac@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from robertshield@chromium.org Link to the patchset: https://codereview.chromium.org/2282143002/#ps20001 (title: "Update with latest trunk.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by pennymac@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [install_static] GetCollectStatsConsentImpl() not returning true early ...when reporting policy enforced. R=robertshield@chromium.org BUG=641540 ========== to ========== [install_static] GetCollectStatsConsentImpl() not returning true early ...when reporting policy enforced. R=robertshield@chromium.org BUG=641540 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [install_static] GetCollectStatsConsentImpl() not returning true early ...when reporting policy enforced. R=robertshield@chromium.org BUG=641540 ========== to ========== [install_static] GetCollectStatsConsentImpl() not returning true early ...when reporting policy enforced. R=robertshield@chromium.org BUG=641540 Committed: https://crrev.com/cacf882777a38c292f82e5b90229bb0b24c9746f Cr-Commit-Position: refs/heads/master@{#415185} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cacf882777a38c292f82e5b90229bb0b24c9746f Cr-Commit-Position: refs/heads/master@{#415185} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
