Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2282103002:
Clamp loopStart to lie in the buffer bounds (Closed)
|
Created:
4 years, 3 months ago by Raymond Toy Modified:
4 years, 3 months ago Reviewers:
hongchan CC:
chromium-reviews, blink-reviews, haraken, Raymond Toy Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionClamp loopStart to lie in the buffer bounds
Internally clamp loopStart to lie within the bounds of the buffer.
Also add some assertions that the read and write indices for the
input and output buffers lie within the expected bounds.
BUG=641234
TEST=
Committed: https://crrev.com/84f16afeecacac71278748e68f4327fb09e831e5
Cr-Commit-Position: refs/heads/master@{#415134}
Patch Set 1 #Patch Set 2 : Check the correct conditions for safety. #Messages
Total messages: 21 (17 generated)
The CQ bit was checked by rtoy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rtoy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Clamp loopStart to lie in the buffer bounds Internally clamp loopStart to lie within the bounds of the buffer. Also add some assertions that the read and write indices for the input and output buffers lie within the expected bounds. BUG=641234 TEST= ========== to ========== Clamp loopStart to lie in the buffer bounds Internally clamp loopStart to lie within the bounds of the buffer. Also add some assertions that the read and write indices for the input and output buffers lie within the expected bounds. BUG=641234 TEST= ==========
hongchan@chromium.org changed reviewers: + hongchan@chromium.org
On 2016/08/29 17:05:46, hoch wrote: > mailto:hongchan@chromium.org changed reviewers: > + mailto:hongchan@chromium.org lgtm
The CQ bit was checked by hongchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hongchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Clamp loopStart to lie in the buffer bounds Internally clamp loopStart to lie within the bounds of the buffer. Also add some assertions that the read and write indices for the input and output buffers lie within the expected bounds. BUG=641234 TEST= ========== to ========== Clamp loopStart to lie in the buffer bounds Internally clamp loopStart to lie within the bounds of the buffer. Also add some assertions that the read and write indices for the input and output buffers lie within the expected bounds. BUG=641234 TEST= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Clamp loopStart to lie in the buffer bounds Internally clamp loopStart to lie within the bounds of the buffer. Also add some assertions that the read and write indices for the input and output buffers lie within the expected bounds. BUG=641234 TEST= ========== to ========== Clamp loopStart to lie in the buffer bounds Internally clamp loopStart to lie within the bounds of the buffer. Also add some assertions that the read and write indices for the input and output buffers lie within the expected bounds. BUG=641234 TEST= Committed: https://crrev.com/84f16afeecacac71278748e68f4327fb09e831e5 Cr-Commit-Position: refs/heads/master@{#415134} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/84f16afeecacac71278748e68f4327fb09e831e5 Cr-Commit-Position: refs/heads/master@{#415134} |
