appengine/findit/handlers/config.py - Issue 2282093002: [Findit] Moving check flake max_builds_to_look_back to config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/handlers/config.py

Issue 2282093002: [Findit] Moving check flake max_builds_to_look_back to config (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/handlers/config.py

diff --git a/appengine/findit/handlers/config.py b/appengine/findit/handlers/config.py

index 5ef2b8bd60f0ce54066a4ebbf49b579748b7e3b0..3fe5e5dc9ddc4e4c22c0eb0c7b4af8b93d15b486 100644

--- a/appengine/findit/handlers/config.py

+++ b/appengine/findit/handlers/config.py

@@ -191,7 +191,8 @@ def _ValidateCheckFlakeSettings(settings):

isinstance(settings.get('upper_flake_threshold'), float) and

isinstance(settings.get('max_flake_in_a_row'), int) and

isinstance(settings.get('max_stable_in_a_row'), int) and

- isinstance(settings.get('iterations_to_rerun'), int))

+ isinstance(settings.get('iterations_to_rerun'), int) and

+ isinstance(settings.get('max_build_numbers_to_look_back'), int))

# Maps config properties to their validation functions.

« no previous file with comments | « no previous file | appengine/findit/handlers/test/config_test.py » ('j') | no next file with comments »