[Findit] Moving check flake max_builds_to_look_back to config

appengine/findit/handlers/test/config_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import json
 import re
 import webapp2
 import webtest
 
@@ skipping 70 matching lines @@
 _MOCK_ACTION_SETTINGS = {
     'cr_notification_build_threshold': 2,
     'cr_notification_latency_limit_minutes': 1000,
 }
 
 _MOCK_CHECK_FLAKE_SETTINGS = {
     'lower_flake_threshold': 0.02,
     'upper_flake_threshold': 0.98,
     'max_flake_in_a_row': 4,
     'max_stable_in_a_row': 4,
-    'iterations_to_rerun': 100
+    'iterations_to_rerun': 100,
+    'max_build_numbers_to_look_back': 1000
 }
 
 _MOCK_VERSION_NUMBER = 12
 
 
 class ConfigTest(testing.AppengineTestCase):
   app_module = webapp2.WSGIApplication([
       ('/config', config.Configuration),
   ], debug=True)
 
@@ skipping 660 matching lines @@
         }))
 
   def testValidateCheckFlakeSettings(self):
     self.assertFalse(config._ValidateCheckFlakeSettings({}))
     self.assertFalse(config._ValidateCheckFlakeSettings(
         {
             'lower_flake_threshold': 1,  # Should be a float.
             'upper_flake_threshold': 0.98,
             'max_flake_in_a_row': 4,
             'max_stable_in_a_row': 4,
-            'iterations_to_rerun': 100
+            'iterations_to_rerun': 100,
+            'max_build_numbers_to_look_back': 1000
         }))
     self.assertFalse(config._ValidateCheckFlakeSettings(
         {
             'lower_flake_threshold': 0.02,
             'upper_flake_threshold': 'a',  # Should be a float.
             'max_flake_in_a_row': 4,
             'max_stable_in_a_row': 4,
-            'iterations_to_rerun': 100
+            'iterations_to_rerun': 100,
+            'max_build_numbers_to_look_back': 1000
         }))
     self.assertFalse(config._ValidateCheckFlakeSettings(
         {
             'lower_flake_threshold': 0.02,
             'upper_flake_threshold': 0.98,
             'max_flake_in_a_row': [],  # Should be an int.
             'max_stable_in_a_row': 4,
-            'iterations_to_rerun': 100
+            'iterations_to_rerun': 100,
+            'max_build_numbers_to_look_back': 1000
         }))
     self.assertFalse(config._ValidateCheckFlakeSettings(
         {
             'lower_flake_threshold': 0.02,
             'upper_flake_threshold': 0.98,
             'max_flake_in_a_row': 4,
             'max_stable_in_a_row': {},  # Should be an int.
-            'iterations_to_rerun': 100
+            'iterations_to_rerun': 100,
+            'max_build_numbers_to_look_back': 1000
         }))
     self.assertFalse(config._ValidateCheckFlakeSettings(
         {
             'lower_flake_threshold': 0.02,
             'upper_flake_threshold': 0.98,
             'max_flake_in_a_row': 4,
             'max_stable_in_a_row': 4,
-            'iterations_to_rerun': 3.2  # Should be an int.
+            'iterations_to_rerun': 3.2,  # Should be an int.
+            'max_build_numbers_to_look_back': 1000
+        }))
+    self.assertFalse(config._ValidateCheckFlakeSettings(
+        {
+            'lower_flake_threshold': 0.02,
+            'upper_flake_threshold': 0.98,
+            'max_flake_in_a_row': 4,
+            'max_stable_in_a_row': 4,
+            'iterations_to_rerun': 4,
+            'max_build_numbers_to_look_back': 'a'  # Should be an int.
         }))
     self.assertTrue(config._ValidateCheckFlakeSettings(
         {
             'lower_flake_threshold': 0.02,
             'upper_flake_threshold': 0.98,
             'max_flake_in_a_row': 4,
             'max_stable_in_a_row': 4,
-            'iterations_to_rerun': 100
+            'iterations_to_rerun': 100,
+            'max_build_numbers_to_look_back': 1000
         }))