Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2282053005: LowMemoryManagement: Deprecate unnecessary calls to Android. (Closed)

Created:
4 years, 3 months ago by cylee1
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LowMemoryManagement: Deprecate unnecessary calls to Android. The following two methods defined in process.mojom are not needed anymore because oom_adj setting and lowmemorykiller are disabled by default on Android side. - DisableBuiltinOomAdjustment() - DisableLowMemoryKiller() BUG=b:30971151 TEST=minnie Committed: https://crrev.com/84f553d3b760d9b45d92f7ea7897c22205d63917 Cr-Commit-Position: refs/heads/master@{#416254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M chrome/browser/memory/tab_manager_delegate_chromeos.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M components/arc/common/process.mojom View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
cylee1
4 years, 3 months ago (2016-08-27 17:23:10 UTC) #2
Luis Héctor Chávez
lgtm
4 years, 3 months ago (2016-08-29 15:22:34 UTC) #3
Yusuke Sato
+rickyz for *.mojom
4 years, 3 months ago (2016-08-29 22:08:17 UTC) #5
rickyz (no longer on Chrome)
mojom lgtm
4 years, 3 months ago (2016-08-29 22:56:27 UTC) #6
Georges Khalil
tab_manager_delegate_chromeos.cc lgtm
4 years, 3 months ago (2016-08-31 21:04:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282053005/1
4 years, 3 months ago (2016-09-02 12:29:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 13:19:27 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 13:21:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84f553d3b760d9b45d92f7ea7897c22205d63917
Cr-Commit-Position: refs/heads/master@{#416254}

Powered by Google App Engine
This is Rietveld 408576698