Remove a use of stl_util in policy.

Remove a use of stl_util in policy.

BUG=555865
Committed: https://crrev.com/472a564ff9e70c80151c73b235059543ff0114a9
Cr-Commit-Position: refs/heads/master@{#415063}

[Avi (use Gerrit), 2016-08-26 19:37:40]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 19:38:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-08-26 20:46:27]

avi@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[commit-bot: I haz the power, 2016-08-26 21:43:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 21:43:15]

Dry run: This issue passed the CQ dry run.

[pastarmovj, 2016-08-29 09:04:04]

https://codereview.chromium.org/2282053004/diff/1/components/policy/core/comm...
File components/policy/core/common/cloud/external_policy_data_fetcher.cc
(right):

https://codereview.chromium.org/2282053004/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/external_policy_data_fetcher.cc:184:
net::URLFetcher* fetcher =
Wouldn't it be better to make this unique_ptr and then move it below instead of
release/WrapUnique-ing it?

https://codereview.chromium.org/2282053004/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/external_policy_data_fetcher.cc:270:
ExternalPolicyDataFetcher::Job* job = it->second->job;
nit: I'd extract the int_64 directly here.

int_64 max_size = it->second->job->max_size;
if (current > max_size || total > max_size) { ...

https://codereview.chromium.org/2282053004/diff/1/components/policy/core/comm...
File components/policy/core/common/cloud/external_policy_data_fetcher.h (right):

https://codereview.chromium.org/2282053004/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/external_policy_data_fetcher.h:178: typedef
std::map<net::URLFetcher*, std::unique_ptr<FetcherAndJob>> JobMap;
Why not directly hold a FetcherAndJob object instead of a pointer to it? Move
semantics should still make this efficient no?

[Avi (use Gerrit), 2016-08-29 16:59:01]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 17:07:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-08-29 18:04:43]

https://codereview.chromium.org/2282053004/diff/1/components/policy/core/comm...
File components/policy/core/common/cloud/external_policy_data_fetcher.cc
(right):

https://codereview.chromium.org/2282053004/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/external_policy_data_fetcher.cc:184:
net::URLFetcher* fetcher =
On 2016/08/29 09:04:04, pastarmovj wrote:
> Wouldn't it be better to make this unique_ptr and then move it below instead
of
> release/WrapUnique-ing it?

Yep.

https://codereview.chromium.org/2282053004/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/external_policy_data_fetcher.cc:270:
ExternalPolicyDataFetcher::Job* job = it->second->job;
On 2016/08/29 09:04:04, pastarmovj wrote:
> nit: I'd extract the int_64 directly here.
> 
> int_64 max_size = it->second->job->max_size;
> if (current > max_size || total > max_size) { ...

Done.

https://codereview.chromium.org/2282053004/diff/1/components/policy/core/comm...
File components/policy/core/common/cloud/external_policy_data_fetcher.h (right):

https://codereview.chromium.org/2282053004/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/external_policy_data_fetcher.h:178: typedef
std::map<net::URLFetcher*, std::unique_ptr<FetcherAndJob>> JobMap;
On 2016/08/29 09:04:04, pastarmovj wrote:
> Why not directly hold a FetcherAndJob object instead of a pointer to it? Move
> semantics should still make this efficient no?

No good reason. This is a remnant of my initial messing around to make it
work...

[Avi (use Gerrit), 2016-08-29 21:49:42]

Done; please take a look.

[pastarmovj, 2016-08-29 22:10:51]

lgtm

[Avi (use Gerrit), 2016-08-29 22:48:57]

The CQ bit was unchecked by avi@chromium.org

[Avi (use Gerrit), 2016-08-29 22:49:10]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-08-29 23:25:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:53:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 03:57:42]

Description was changed from

==========
Remove a use of stl_util in policy.

BUG=555865
==========

to

==========
Remove a use of stl_util in policy.

BUG=555865

Committed: https://crrev.com/472a564ff9e70c80151c73b235059543ff0114a9
Cr-Commit-Position: refs/heads/master@{#415063}
==========

[commit-bot: I haz the power, 2016-08-30 03:57:43]

Patchset 2 (id:??) landed as
https://crrev.com/472a564ff9e70c80151c73b235059543ff0114a9
Cr-Commit-Position: refs/heads/master@{#415063}