Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: src/objects.cc

Issue 228203003: Fix MUST_USE_RESULT warning. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3781 matching lines...) Expand 10 before | Expand all | Expand 10 after
3792 writable = isolate->factory()->ToBoolean(!setter->IsUndefined()); 3792 writable = isolate->factory()->ToBoolean(!setter->IsUndefined());
3793 } 3793 }
3794 3794
3795 if (configurable->IsFalse()) { 3795 if (configurable->IsFalse()) {
3796 Handle<Object> handler(proxy->handler(), isolate); 3796 Handle<Object> handler(proxy->handler(), isolate);
3797 Handle<String> trap = isolate->factory()->InternalizeOneByteString( 3797 Handle<String> trap = isolate->factory()->InternalizeOneByteString(
3798 STATIC_ASCII_VECTOR("getPropertyDescriptor")); 3798 STATIC_ASCII_VECTOR("getPropertyDescriptor"));
3799 Handle<Object> args[] = { handler, trap, name }; 3799 Handle<Object> args[] = { handler, trap, name };
3800 Handle<Object> error = isolate->factory()->NewTypeError( 3800 Handle<Object> error = isolate->factory()->NewTypeError(
3801 "proxy_prop_not_configurable", HandleVector(args, ARRAY_SIZE(args))); 3801 "proxy_prop_not_configurable", HandleVector(args, ARRAY_SIZE(args)));
3802 isolate->Throw<Object>(error); 3802 isolate->Throw(*error);
3803 return NONE; 3803 return NONE;
3804 } 3804 }
3805 3805
3806 int attributes = NONE; 3806 int attributes = NONE;
3807 if (!enumerable->BooleanValue()) attributes |= DONT_ENUM; 3807 if (!enumerable->BooleanValue()) attributes |= DONT_ENUM;
3808 if (!configurable->BooleanValue()) attributes |= DONT_DELETE; 3808 if (!configurable->BooleanValue()) attributes |= DONT_DELETE;
3809 if (!writable->BooleanValue()) attributes |= READ_ONLY; 3809 if (!writable->BooleanValue()) attributes |= READ_ONLY;
3810 return static_cast<PropertyAttributes>(attributes); 3810 return static_cast<PropertyAttributes>(attributes);
3811 } 3811 }
3812 3812
(...skipping 12898 matching lines...) Expand 10 before | Expand all | Expand 10 after
16711 #define ERROR_MESSAGES_TEXTS(C, T) T, 16711 #define ERROR_MESSAGES_TEXTS(C, T) T,
16712 static const char* error_messages_[] = { 16712 static const char* error_messages_[] = {
16713 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 16713 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
16714 }; 16714 };
16715 #undef ERROR_MESSAGES_TEXTS 16715 #undef ERROR_MESSAGES_TEXTS
16716 return error_messages_[reason]; 16716 return error_messages_[reason];
16717 } 16717 }
16718 16718
16719 16719
16720 } } // namespace v8::internal 16720 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698