arc: Support window recreation.

arc: Support window recreation.

In some cases, Arc window may be destroyed and created again. This
leads to situation when shelf item is closed and there is no longer
item for Arc task. This CL allows Arc window to be recreated. The
situation may go even worse, window may be destroyed and not created
after. In this case we have task without window. In this case, we
send launch request to Android and this put Android task to foreground
and window is created.

BUG=b/31071902
TEST=Manually on device, installed several photo editor apps as
     described in task. Minimize/maximize window. Sometimes window
     get destroyed and created again. Shelf item is not lost in this
     case. Sometimes window destroyed and not recreated. Shelf icon
     still exists and clicking on it gets new window back for task.
TEST=Extended unit_tests

Committed: https://crrev.com/a4c117d63a677ab01edf04b96dac78134347bf82
Cr-Commit-Position: refs/heads/master@{#415136}

[khmel, 2016-08-26 17:50:03]

khmel@chromium.org changed reviewers:
+ reveman@chromium.org, skuhne@chromium.org

[khmel, 2016-08-26 17:50:03]

Hi Stefan and David,

PTAL

https://codereview.chromium.org/2282023002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h (left):

https://codereview.chromium.org/2282023002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h:88: struct
TaskInfo;
Actually only mapping task_id -> shelf_app_id is required. Can drop TaskInfo

[khmel, 2016-08-26 19:46:04]

Changed App launch to SetTaskActive in case window is not available.

PTAL

[Mr4D (OOO till 08-26), 2016-08-26 22:54:43]

I think this is ok - but please also wait for reveman.
lgtm

https://codereview.chromium.org/2282023002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
(right):

https://codereview.chromium.org/2282023002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc:28:
ArcAppWindowLauncherItemController::ItemSelected(const ui::Event& eent) {
eent -> event?

https://codereview.chromium.org/2282023002/diff/20001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
(right):

https://codereview.chromium.org/2282023002/diff/20001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc:37:
ArcAppWindowLauncherItemController::ItemSelected(const ui::Event& eent) {
event?

[reveman, 2016-08-26 23:20:59]

sounds reasonable, lgtm. I'll leave the actual code review to skuhne@.

[khmel, 2016-08-29 16:31:52]

The CQ bit was checked by khmel@chromium.org

[khmel, 2016-08-29 16:31:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, skuhne@chromium.org
Link to the patchset: https://codereview.chromium.org/2282023002/#ps40001
(title: "rebase + nits")

[khmel, 2016-08-29 16:41:03]

khmel@chromium.org changed reviewers:
+ xiyuan@chromium.org

[khmel, 2016-08-29 16:41:04]

Thanks Stefan and David for review.

Adding Xiyuan,

c/b/ui/app_list/arc/arc_app_utils.*

PTAL

https://codereview.chromium.org/2282023002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
(right):

https://codereview.chromium.org/2282023002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc:28:
ArcAppWindowLauncherItemController::ItemSelected(const ui::Event& eent) {
On 2016/08/26 22:54:43, Mr4D wrote:
> eent -> event?

Done.

https://codereview.chromium.org/2282023002/diff/20001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
(right):

https://codereview.chromium.org/2282023002/diff/20001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc:37:
ArcAppWindowLauncherItemController::ItemSelected(const ui::Event& eent) {
On 2016/08/26 22:54:43, Mr4D wrote:
> event?

Done.

[commit-bot: I haz the power, 2016-08-29 16:45:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 16:55:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 16:55:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xiyuan, 2016-08-29 17:11:54]

arc_app_utils.* lgtm

[khmel, 2016-08-29 18:02:52]

The CQ bit was checked by khmel@chromium.org

[commit-bot: I haz the power, 2016-08-29 18:26:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[khmel, 2016-08-29 21:27:46]

The CQ bit was unchecked by khmel@chromium.org

[khmel, 2016-08-29 21:27:52]

The CQ bit was checked by khmel@chromium.org

[commit-bot: I haz the power, 2016-08-29 21:53:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:07:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-30 05:09:45]

Description was changed from

==========
arc: Support window recreation.

In some cases, Arc window may be destroyed and created again. This
leads to situation when shelf item is closed and there is no longer
item for Arc task. This CL allows Arc window to be recreated. The
situation may go even worse, window may be destroyed and not created
after. In this case we have task without window. In this case, we
send launch request to Android and this put Android task to foreground
and window is created.

BUG=b/31071902
TEST=Manually on device, installed several photo editor apps as
     described in task. Minimize/maximize window. Sometimes window
     get destroyed and created again. Shelf item is not lost in this
     case. Sometimes window destroyed and not recreated. Shelf icon
     still exists and clicking on it gets new window back for task.
TEST=Extended unit_tests
==========

to

==========
arc: Support window recreation.

In some cases, Arc window may be destroyed and created again. This
leads to situation when shelf item is closed and there is no longer
item for Arc task. This CL allows Arc window to be recreated. The
situation may go even worse, window may be destroyed and not created
after. In this case we have task without window. In this case, we
send launch request to Android and this put Android task to foreground
and window is created.

BUG=b/31071902
TEST=Manually on device, installed several photo editor apps as
     described in task. Minimize/maximize window. Sometimes window
     get destroyed and created again. Shelf item is not lost in this
     case. Sometimes window destroyed and not recreated. Shelf icon
     still exists and clicking on it gets new window back for task.
TEST=Extended unit_tests

Committed: https://crrev.com/a4c117d63a677ab01edf04b96dac78134347bf82
Cr-Commit-Position: refs/heads/master@{#415136}
==========

[commit-bot: I haz the power, 2016-08-30 05:09:46]

Patchset 3 (id:??) landed as
https://crrev.com/a4c117d63a677ab01edf04b96dac78134347bf82
Cr-Commit-Position: refs/heads/master@{#415136}