Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java

Issue 2281983004: [Remoting Android] Move setAnimationEnabled to TouchInputHandler (Closed)
Patch Set: Reviewer's Feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java b/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
index af8f6fa82976e20f2ed25d0cdd1ac5663e02b1d2..4f47e925154ebfe3d942f600ea7450c2958361a8 100644
--- a/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
+++ b/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
@@ -21,8 +21,6 @@ public class GlDesktopView extends DesktopView implements SurfaceHolder.Callback
private Object mOnHostSizeChangedListenerKey;
private Object mOnCanvasRenderedListenerKey;
- private Event.ParameterRunnable<Void> mProcessAnimationRunnable;
-
private float mScaleFactor;
public GlDesktopView(GlDisplay display, Desktop desktop, Client client) {
@@ -30,13 +28,6 @@ public class GlDesktopView extends DesktopView implements SurfaceHolder.Callback
Preconditions.notNull(display);
mDisplay = display;
- mProcessAnimationRunnable = new Event.ParameterRunnable<Void>() {
- @Override
- public void run(Void p) {
- mInputHandler.processAnimation();
- }
- };
-
mScaleFactor = 0;
getHolder().addCallback(this);
@@ -70,18 +61,6 @@ public class GlDesktopView extends DesktopView implements SurfaceHolder.Callback
}
@Override
- public void setAnimationEnabled(boolean enabled) {
- if (enabled && mOnCanvasRenderedListenerKey == null) {
- mOnCanvasRenderedListenerKey = mDisplay.onCanvasRendered()
- .add(mProcessAnimationRunnable);
- mInputHandler.processAnimation();
- } else if (!enabled && mOnCanvasRenderedListenerKey != null) {
- mDisplay.onCanvasRendered().remove(mOnCanvasRenderedListenerKey);
- mOnCanvasRenderedListenerKey = null;
- }
- }
-
- @Override
public void surfaceCreated(SurfaceHolder holder) {
mOnHostSizeChangedListenerKey = mDisplay
.onHostSizeChanged().add(new Event.ParameterRunnable<SizeChangedEventParameter>() {
@@ -91,6 +70,14 @@ public class GlDesktopView extends DesktopView implements SurfaceHolder.Callback
}
});
+ mOnCanvasRenderedListenerKey = mDisplay
+ .onCanvasRendered().add(new Event.ParameterRunnable<Void>() {
+ @Override
+ public void run(Void p) {
+ mOnCanvasRendered.raise(p);
+ }
+ });
+
mDisplay.surfaceCreated(holder.getSurface());
}

Powered by Google App Engine
This is Rietveld 408576698