Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2281983003:
[CacheStorage] Filter entries while iterating the backend (Closed)
Description[CacheStorage] Filter entries while iterating the backend
Due to issues with the MemoryCache backend QueryCache wasn't allowed to read
cache entries as it iterated them. That's been fixed, so now it's safe to
filter entries as they're iterated, which is more resource friendly.
BUG=634428
Committed: https://crrev.com/68c9273ddeceb899b6086126f26e0146276f7bdb
Cr-Commit-Position: refs/heads/master@{#415180}
Patch Set 1 #Patch Set 2 : Nits #Patch Set 3 : Nit #Patch Set 4 : Rebase #
Depends on Patchset: Messages
Total messages: 32 (22 generated)
The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
Description was changed from ========== [CacheStorage] Don't open all the entries before filtering in QueryCache Due to issues with the MemoryCache backend QueryCache wasn't allowed to read cache entries as it iterated them. That's been fixed, so now it's safe to filter entries as they're iterated, which is more resource friendly. BUG=634428 ========== to ========== [CacheStorage] Filter entries while iterating the backend Due to issues with the MemoryCache backend QueryCache wasn't allowed to read cache entries as it iterated them. That's been fixed, so now it's safe to filter entries as they're iterated, which is more resource friendly. BUG=634428 ==========
The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jkarlin@chromium.org changed reviewers: + nhiroki@chromium.org
nhiroki@ PTAL, many thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
LGTM!
The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thank you!
The CQ bit was unchecked by jkarlin@chromium.org
The CQ bit was checked by jkarlin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org Link to the patchset: https://codereview.chromium.org/2281983003/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jkarlin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dsansome@chromium.org
dsansome@chromium.org changed reviewers: + dsansome@chromium.org
(I unset the commit bit on this change to try fix a stuck CQ - https://bugs.chromium.org/p/chromium/issues/detail?id=642077. The issue is fixed now so I'm sending this to CQ again for you)
The CQ bit was checked by dsansome@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [CacheStorage] Filter entries while iterating the backend Due to issues with the MemoryCache backend QueryCache wasn't allowed to read cache entries as it iterated them. That's been fixed, so now it's safe to filter entries as they're iterated, which is more resource friendly. BUG=634428 ========== to ========== [CacheStorage] Filter entries while iterating the backend Due to issues with the MemoryCache backend QueryCache wasn't allowed to read cache entries as it iterated them. That's been fixed, so now it's safe to filter entries as they're iterated, which is more resource friendly. BUG=634428 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [CacheStorage] Filter entries while iterating the backend Due to issues with the MemoryCache backend QueryCache wasn't allowed to read cache entries as it iterated them. That's been fixed, so now it's safe to filter entries as they're iterated, which is more resource friendly. BUG=634428 ========== to ========== [CacheStorage] Filter entries while iterating the backend Due to issues with the MemoryCache backend QueryCache wasn't allowed to read cache entries as it iterated them. That's been fixed, so now it's safe to filter entries as they're iterated, which is more resource friendly. BUG=634428 Committed: https://crrev.com/68c9273ddeceb899b6086126f26e0146276f7bdb Cr-Commit-Position: refs/heads/master@{#415180} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/68c9273ddeceb899b6086126f26e0146276f7bdb Cr-Commit-Position: refs/heads/master@{#415180} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
