No initial focusing of buttons in the message center bubble

No initial focusing of buttons in the message center bubble

Unless the user manually tabs in the message center bubble, we shouldn't request
the focus by default to prevent the ugly blue border from showing automatically
[See screenshot: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LelZhbUN2aWtMSzg/view?usp=sharing]

BUG=620801
Committed: https://crrev.com/910a888e51a6544f8092e748166173bf13af32b1
Cr-Commit-Position: refs/heads/master@{#414779}

[afakhry, 2016-08-26 16:39:38]

afakhry@chromium.org changed reviewers:
+ stevenjb@chromium.org

[afakhry, 2016-08-26 16:39:39]

Steven, please review. Thanks!

[afakhry, 2016-08-26 16:40:36]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 16:41:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2016-08-26 16:46:29]

On 2016/08/26 16:39:39, afakhry wrote:
> Steven, please review. Thanks!

Please rename this to reflect the actual change (not initially focusing a
button). Changing the focus look is a separate issue.

[afakhry, 2016-08-26 16:50:53]

Description was changed from

==========
Prevent the ugly blue border from showing by default in the message center
bubble

Unless the user manually tabs in the message center bubble, we shouldn't request
the focus by default to prevent the ugly blue border from showing automatically
[See screenshot:
https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LelZhbUN2aWtMSzg/vie...

BUG=620801
==========

to

==========
No initial focusing of buttons in the message center bubble

Unless the user manually tabs in the message center bubble, we shouldn't request
the focus by default to prevent the ugly blue border from showing automatically
[See screenshot:
https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LelZhbUN2aWtMSzg/vie...

BUG=620801
==========

[afakhry, 2016-08-26 16:52:12]

Done.

[stevenjb, 2016-08-26 17:00:59]

https://codereview.chromium.org/2281983002/diff/1/ui/message_center/views/mes...
File ui/message_center/views/message_center_bubble.cc (left):

https://codereview.chromium.org/2281983002/diff/1/ui/message_center/views/mes...
ui/message_center/views/message_center_bubble.cc:118:
next_focusable_view->RequestFocus();
I assume that when this is removed, 'tab' still focuses the first button as
expected?

[afakhry, 2016-08-26 18:03:46]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[afakhry, 2016-08-26 18:04:10]

https://codereview.chromium.org/2281983002/diff/1/ui/message_center/views/mes...
File ui/message_center/views/message_center_bubble.cc (left):

https://codereview.chromium.org/2281983002/diff/1/ui/message_center/views/mes...
ui/message_center/views/message_center_bubble.cc:118:
next_focusable_view->RequestFocus();
On 2016/08/26 17:00:59, stevenjb wrote:
> I assume that when this is removed, 'tab' still focuses the first button as
> expected?

Yes, correct.

[commit-bot: I haz the power, 2016-08-26 18:04:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2016-08-26 18:14:02]

OK, lgtm

[afakhry, 2016-08-26 18:51:08]

The CQ bit was unchecked by afakhry@chromium.org

[afakhry, 2016-08-26 18:51:09]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2016-08-26 18:51:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 19:35:19]

Description was changed from

==========
No initial focusing of buttons in the message center bubble

Unless the user manually tabs in the message center bubble, we shouldn't request
the focus by default to prevent the ugly blue border from showing automatically
[See screenshot:
https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LelZhbUN2aWtMSzg/vie...

BUG=620801
==========

to

==========
No initial focusing of buttons in the message center bubble

Unless the user manually tabs in the message center bubble, we shouldn't request
the focus by default to prevent the ugly blue border from showing automatically
[See screenshot:
https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LelZhbUN2aWtMSzg/vie...

BUG=620801
==========

[commit-bot: I haz the power, 2016-08-26 19:35:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-26 19:37:55]

Description was changed from

==========
No initial focusing of buttons in the message center bubble

Unless the user manually tabs in the message center bubble, we shouldn't request
the focus by default to prevent the ugly blue border from showing automatically
[See screenshot:
https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LelZhbUN2aWtMSzg/vie...

BUG=620801
==========

to

==========
No initial focusing of buttons in the message center bubble

Unless the user manually tabs in the message center bubble, we shouldn't request
the focus by default to prevent the ugly blue border from showing automatically
[See screenshot:
https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LelZhbUN2aWtMSzg/vie...

BUG=620801

Committed: https://crrev.com/910a888e51a6544f8092e748166173bf13af32b1
Cr-Commit-Position: refs/heads/master@{#414779}
==========

[commit-bot: I haz the power, 2016-08-26 19:37:56]

Patchset 3 (id:??) landed as
https://crrev.com/910a888e51a6544f8092e748166173bf13af32b1
Cr-Commit-Position: refs/heads/master@{#414779}