Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: gm/circulararcs.cpp

Issue 2281953002: avoid generating degenerate conic from arc (Closed)
Patch Set: add isolated test case Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkGeometry.cpp » ('j') | src/core/SkGeometry.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/circulararcs.cpp
diff --git a/gm/circulararcs.cpp b/gm/circulararcs.cpp
index 148ee42169a8968b4a09081988f78a867ede412b..c81d12d0f1c09873f6375e9b5c9f4fad04b502e6 100644
--- a/gm/circulararcs.cpp
+++ b/gm/circulararcs.cpp
@@ -210,3 +210,26 @@ DEF_SIMPLE_GM(circular_arcs_weird, canvas, 1000, 400) {
canvas->translate(0, kS + kPad);
}
}
+
+DEF_SIMPLE_GM(onebadarc, canvas, 100, 100) {
+ SkPath path;
+ path.moveTo(SkBits2Float(0x41a00000), SkBits2Float(0x41a00000)); // 20, 20
+ path.lineTo(SkBits2Float(0x4208918c), SkBits2Float(0x4208918c)); // 34.1421f, 34.1421f
+ path.conicTo(SkBits2Float(0x41a00000), SkBits2Float(0x42412318), // 20, 48.2843f
+ SkBits2Float(0x40bb73a0), SkBits2Float(0x4208918c), // 5.85786f, 34.1421f
+ SkBits2Float(0x3f3504f3)); // 0.707107f
+ path.quadTo(SkBits2Float(0x40bb73a0), SkBits2Float(0x4208918c), // 5.85786f, 34.1421f
+ SkBits2Float(0x40bb73a2), SkBits2Float(0x4208918c)); // 5.85787f, 34.1421f
+ path.lineTo(SkBits2Float(0x41a00000), SkBits2Float(0x41a00000)); // 20, 20
+ path.close();
+ SkPaint p0;
+ p0.setColor(SK_ColorRED);
+ p0.setStrokeWidth(15.f);
+ p0.setStyle(SkPaint::kStroke_Style);
+ p0.setAlpha(100);
+ canvas->translate(20, 0);
+ canvas->drawPath(path, p0);
+
+ SkRect kRect = { 60, 0, 100, 40};
+ canvas->drawArc(kRect, 45, 90, true, p0);
+}
« no previous file with comments | « no previous file | src/core/SkGeometry.cpp » ('j') | src/core/SkGeometry.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698