Add page_load_metrics for css scanning experiment

Add page_load_metrics for css scanning experiment

For now, let's just add metrics from parse start -> first meaningful paint.

TBR=jochen@chromium.org

BUG=596676
Committed: https://crrev.com/9d927401e76298dbc5151cc80465220dc40316fe
Cr-Commit-Position: refs/heads/master@{#415681}

[Charlie Harrison, 2016-08-26 14:37:50]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 14:38:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-08-26 19:55:14]

csharrison@chromium.org changed reviewers:
+ mpearson@chromium.org, shivanisha@chromium.org

[Charlie Harrison, 2016-08-26 19:55:14]

+shivanisha would you look at page_load_metrics changes?

+mpearson for histograms.xml

Thanks!

[shivanisha, 2016-08-29 15:27:35]

On 2016/08/26 at 19:55:14, csharrison wrote:
> +shivanisha would you look at page_load_metrics changes?
> 
> +mpearson for histograms.xml
> 
> Thanks!

lgtm with a nit.

[shivanisha, 2016-08-29 15:28:05]

https://codereview.chromium.org/2281943002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2281943002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:102255: +      label="Metrics from pages
with external css scanned @import rules"/>
May be add the term "preload" in the description,
"Metrics from pages scanned by the preload scanner for @import CSS rules"?

[Mark P, 2016-08-30 23:25:41]

https://codereview.chromium.org/2281943002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2281943002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:102254: +  <suffix
name="Clients.CssScanner"
Um, why did you put this in the pageloadmetricsabortclients section?  As near as
I can tell, this should go in the pageloadmetricsclients section.  Am I missing
something?

[Charlie Harrison, 2016-08-31 00:07:02]

https://codereview.chromium.org/2281943002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2281943002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:102254: +  <suffix
name="Clients.CssScanner"
On 2016/08/30 23:25:41, Mark P wrote:
> Um, why did you put this in the pageloadmetricsabortclients section?  As near
as
> I can tell, this should go in the pageloadmetricsclients section.  Am I
missing
> something?

...Good catch this is definitely an error. Thanks for catching it. I'll upload
an amended patch shortly.

[Charlie Harrison, 2016-08-31 04:34:03]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 04:34:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 05:57:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 05:57:06]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2016-08-31 12:38:20]

mpearson: Fixed the xml issue.

https://codereview.chromium.org/2281943002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2281943002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:102255: +      label="Metrics from pages
with external css scanned @import rules"/>
On 2016/08/29 15:28:05, shivanisha wrote:
> May be add the term "preload" in the description,
> "Metrics from pages scanned by the preload scanner for @import CSS rules"?

Done.

[Mark P, 2016-08-31 17:17:10]

histograms.xml lgtm

[Charlie Harrison, 2016-08-31 17:59:03]

Description was changed from

==========
Add page_load_metrics for css scanning experiment

For now, let's just add metrics from parse start -> first meaningful paint.

BUG=596676
==========

to

==========
Add page_load_metrics for css scanning experiment

For now, let's just add metrics from parse start -> first meaningful paint.

TBR=jochen@chromiun.org

BUG=596676
==========

[Charlie Harrison, 2016-08-31 17:59:15]

Description was changed from

==========
Add page_load_metrics for css scanning experiment

For now, let's just add metrics from parse start -> first meaningful paint.

TBR=jochen@chromiun.org

BUG=596676
==========

to

==========
Add page_load_metrics for css scanning experiment

For now, let's just add metrics from parse start -> first meaningful paint.

TBR=jochen@chromium.org

BUG=596676
==========

[Charlie Harrison, 2016-08-31 18:00:02]

csharrison@chromium.org changed reviewers:
+ jochen@chromium.org

[Charlie Harrison, 2016-08-31 18:00:03]

+jochen TBR for BUILD.gn change. chrome_browser.gypi used to be owned by
everyone so I feel like the same applies here.

[Charlie Harrison, 2016-08-31 18:00:14]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2016-08-31 18:00:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
shivanisha@chromium.org
Link to the patchset: https://codereview.chromium.org/2281943002/#ps40001
(title: "rebase and fix up xml")

[commit-bot: I haz the power, 2016-08-31 18:00:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 18:10:45]

Description was changed from

==========
Add page_load_metrics for css scanning experiment

For now, let's just add metrics from parse start -> first meaningful paint.

TBR=jochen@chromium.org

BUG=596676
==========

to

==========
Add page_load_metrics for css scanning experiment

For now, let's just add metrics from parse start -> first meaningful paint.

TBR=jochen@chromium.org

BUG=596676
==========

[commit-bot: I haz the power, 2016-08-31 18:10:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-31 18:14:04]

Description was changed from

==========
Add page_load_metrics for css scanning experiment

For now, let's just add metrics from parse start -> first meaningful paint.

TBR=jochen@chromium.org

BUG=596676
==========

to

==========
Add page_load_metrics for css scanning experiment

For now, let's just add metrics from parse start -> first meaningful paint.

TBR=jochen@chromium.org

BUG=596676

Committed: https://crrev.com/9d927401e76298dbc5151cc80465220dc40316fe
Cr-Commit-Position: refs/heads/master@{#415681}
==========

[commit-bot: I haz the power, 2016-08-31 18:14:05]

Patchset 3 (id:??) landed as
https://crrev.com/9d927401e76298dbc5151cc80465220dc40316fe
Cr-Commit-Position: refs/heads/master@{#415681}