chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java - Issue 2281913002: Currency code exceeding 6 chars will be ellipsized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2281913002: Currency code exceeding 6 chars will be ellipsized. (Closed)

Patch Set: formatCurrency() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyStringFormatter.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyStringFormatter.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

index e57ff7617dce074584ab970ad3309cd906e97d0e..c1820b10dee50f07012636d1de6f14d48c4a7d1b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

@@ -490,7 +490,8 @@ public class PaymentRequestImpl implements PaymentRequest, PaymentRequestUI.Clie

}

LineItem uiTotal = new LineItem(

- details.total.label, totalCurrency, formatter.format(details.total.amount.value));

+ details.total.label, formatter.formatCurrency(totalCurrency),

please use gerrit instead 2016/09/02 17:30:55 formatter.getFormattedCurrencyCode(),

pals 2016/09/06 06:09:00 Done.

+ formatter.format(details.total.amount.value));

List<LineItem> uiLineItems = getValidatedLineItems(details.displayItems, totalCurrency,

formatter);