Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2281903003: Added quicks support to Observatory eval-box element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added quickExpressions support to Observatory eval-box element R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/9a18a1b5eb5535666c6bb94e5d55ca49109e3507

Patch Set 1 #

Total comments: 2

Patch Set 2 : Renamed quicks in quickExpressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M runtime/observatory/lib/src/elements/css/shared.css View 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/eval_box.dart View 1 4 chunks +15 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/eval_box_wrapper.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
cbernaschina
4 years, 3 months ago (2016-08-27 01:21:55 UTC) #2
rmacnak
lgtm https://chromiumcodereview.appspot.com/2281903003/diff/1/runtime/observatory/lib/src/elements/eval_box.dart File runtime/observatory/lib/src/elements/eval_box.dart (right): https://chromiumcodereview.appspot.com/2281903003/diff/1/runtime/observatory/lib/src/elements/eval_box.dart#newcode32 runtime/observatory/lib/src/elements/eval_box.dart:32: Iterable<String> _quicks; It's not obvious from "quick" by ...
4 years, 3 months ago (2016-08-29 19:33:23 UTC) #3
cbernaschina
https://codereview.chromium.org/2281903003/diff/1/runtime/observatory/lib/src/elements/eval_box.dart File runtime/observatory/lib/src/elements/eval_box.dart (right): https://codereview.chromium.org/2281903003/diff/1/runtime/observatory/lib/src/elements/eval_box.dart#newcode32 runtime/observatory/lib/src/elements/eval_box.dart:32: Iterable<String> _quicks; On 2016/08/29 19:33:23, rmacnak wrote: > It's ...
4 years, 3 months ago (2016-08-29 19:35:31 UTC) #4
cbernaschina
4 years, 3 months ago (2016-08-29 19:36:32 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
9a18a1b5eb5535666c6bb94e5d55ca49109e3507 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698