Tracing V2: Trace buffer writer uses proto.

Tracing V2: Trace buffer writer uses proto.

Integration between newly indroduced trace buffer writer
and proto generated stubs.

BUG=608719
Committed: https://crrev.com/f2a06ae75dc4d204daeb03f7fd6d6d771b4ac774
Cr-Commit-Position: refs/heads/master@{#414739}

[kraynov, 2016-08-26 11:51:06]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 11:51:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kraynov, 2016-08-26 11:52:42]

kraynov@chromium.org changed reviewers:
+ primiano@chromium.org

[kraynov, 2016-08-26 11:52:42]

PTAL

[commit-bot: I haz the power, 2016-08-26 13:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 13:13:35]

Dry run: This issue passed the CQ dry run.

[Primiano Tucci (use gerrit), 2016-08-26 14:27:32]

Thanks, makes great sense. Just minor comments.
I actually needed this CL right now :)

https://codereview.chromium.org/2281903002/diff/1/components/tracing/core/tra...
File components/tracing/core/trace_buffer_writer_unittest.cc (right):

https://codereview.chromium.org/2281903002/diff/1/components/tracing/core/tra...
components/tracing/core/trace_buffer_writer_unittest.cc:10: #include
"components/tracing/proto/events_chunk.pb.h"
can we keep this in test/golden_protos? I feel it was a bit more readable
keeping in that folder.

https://codereview.chromium.org/2281903002/diff/1/components/tracing/proto/BU...
File components/tracing/proto/BUILD.gn (right):

https://codereview.chromium.org/2281903002/diff/1/components/tracing/proto/BU...
components/tracing/proto/BUILD.gn:7: protos = [
Oh I see what you are doing here, but I'd explicitly list them in the sources.
The thing is for the golden protos we need only event_chunk.proto, while for the
tracing_protos we will need all events and args.

[kraynov, 2016-08-26 14:46:08]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 14:46:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2016-08-26 15:15:13]

LGTM

https://codereview.chromium.org/2281903002/diff/20001/components/tracing/core...
File components/tracing/core/trace_buffer_writer_unittest.cc (right):

https://codereview.chromium.org/2281903002/diff/20001/components/tracing/core...
components/tracing/core/trace_buffer_writer_unittest.cc:10: #include
"components/tracing/test/golden_tracing_protos/events_chunk.pb.h"
probably a bit redundant as the outer folder is called "tracing".

https://codereview.chromium.org/2281903002/diff/20001/components/tracing/prot...
File components/tracing/proto/BUILD.gn (right):

https://codereview.chromium.org/2281903002/diff/20001/components/tracing/prot...
components/tracing/proto/BUILD.gn:26:
proto_library("golden_tracing_protos_for_tests") {
ditto here (redundancy of "tracing"), as this is already in //components/tracing

[kraynov, 2016-08-26 15:46:25]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 15:46:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 16:50:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 16:50:34]

Dry run: This issue passed the CQ dry run.

[kraynov, 2016-08-26 17:11:57]

The CQ bit was checked by kraynov@chromium.org

[kraynov, 2016-08-26 17:11:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/2281903002/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-08-26 17:12:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 17:17:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-26 17:19:51]

Description was changed from

==========
Tracing V2: Trace buffer writer uses proto.

Integration between newly indroduced trace buffer writer
and proto generated stubs.

BUG=608719
==========

to

==========
Tracing V2: Trace buffer writer uses proto.

Integration between newly indroduced trace buffer writer
and proto generated stubs.

BUG=608719

Committed: https://crrev.com/f2a06ae75dc4d204daeb03f7fd6d6d771b4ac774
Cr-Commit-Position: refs/heads/master@{#414739}
==========

[commit-bot: I haz the power, 2016-08-26 17:19:53]

Patchset 3 (id:??) landed as
https://crrev.com/f2a06ae75dc4d204daeb03f7fd6d6d771b4ac774
Cr-Commit-Position: refs/heads/master@{#414739}