Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 22819011: Fix replaying of captured objects during chunk building. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment by Ben Titzer. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | test/mjsunit/compiler/escape-analysis.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2356 matching lines...) Expand 10 before | Expand all | Expand 10 after
2367 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) { 2367 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) {
2368 // There are no real uses of the arguments object. 2368 // There are no real uses of the arguments object.
2369 // arguments.length and element access are supported directly on 2369 // arguments.length and element access are supported directly on
2370 // stack arguments, and any real arguments object use causes a bailout. 2370 // stack arguments, and any real arguments object use causes a bailout.
2371 // So this value is never used. 2371 // So this value is never used.
2372 return NULL; 2372 return NULL;
2373 } 2373 }
2374 2374
2375 2375
2376 LInstruction* LChunkBuilder::DoCapturedObject(HCapturedObject* instr) { 2376 LInstruction* LChunkBuilder::DoCapturedObject(HCapturedObject* instr) {
2377 HEnvironment* env = current_block_->last_environment();
2378 instr->ReplayEnvironment(env);
2379
2377 // There are no real uses of a captured object. 2380 // There are no real uses of a captured object.
2378 return NULL; 2381 return NULL;
2379 } 2382 }
2380 2383
2381 2384
2382 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) { 2385 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) {
2383 info()->MarkAsRequiresFrame(); 2386 info()->MarkAsRequiresFrame();
2384 LOperand* args = UseRegister(instr->arguments()); 2387 LOperand* args = UseRegister(instr->arguments());
2385 LOperand* length; 2388 LOperand* length;
2386 LOperand* index; 2389 LOperand* index;
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
2527 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2530 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2528 LOperand* object = UseRegister(instr->object()); 2531 LOperand* object = UseRegister(instr->object());
2529 LOperand* index = UseTempRegister(instr->index()); 2532 LOperand* index = UseTempRegister(instr->index());
2530 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2533 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2531 } 2534 }
2532 2535
2533 2536
2534 } } // namespace v8::internal 2537 } } // namespace v8::internal
2535 2538
2536 #endif // V8_TARGET_ARCH_X64 2539 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | test/mjsunit/compiler/escape-analysis.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698