Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 22819011: Fix replaying of captured objects during chunk building. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment by Ben Titzer. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2546 matching lines...) Expand 10 before | Expand all | Expand 10 after
2557 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) { 2557 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) {
2558 // There are no real uses of the arguments object. 2558 // There are no real uses of the arguments object.
2559 // arguments.length and element access are supported directly on 2559 // arguments.length and element access are supported directly on
2560 // stack arguments, and any real arguments object use causes a bailout. 2560 // stack arguments, and any real arguments object use causes a bailout.
2561 // So this value is never used. 2561 // So this value is never used.
2562 return NULL; 2562 return NULL;
2563 } 2563 }
2564 2564
2565 2565
2566 LInstruction* LChunkBuilder::DoCapturedObject(HCapturedObject* instr) { 2566 LInstruction* LChunkBuilder::DoCapturedObject(HCapturedObject* instr) {
2567 HEnvironment* env = current_block_->last_environment();
2568 instr->ReplayEnvironment(env);
2569
2567 // There are no real uses of a captured object. 2570 // There are no real uses of a captured object.
2568 return NULL; 2571 return NULL;
2569 } 2572 }
2570 2573
2571 2574
2572 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) { 2575 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) {
2573 info()->MarkAsRequiresFrame(); 2576 info()->MarkAsRequiresFrame();
2574 LOperand* args = UseRegister(instr->arguments()); 2577 LOperand* args = UseRegister(instr->arguments());
2575 LOperand* length; 2578 LOperand* length;
2576 LOperand* index; 2579 LOperand* index;
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
2723 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2726 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2724 LOperand* object = UseRegister(instr->object()); 2727 LOperand* object = UseRegister(instr->object());
2725 LOperand* index = UseTempRegister(instr->index()); 2728 LOperand* index = UseTempRegister(instr->index());
2726 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2729 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2727 } 2730 }
2728 2731
2729 2732
2730 } } // namespace v8::internal 2733 } } // namespace v8::internal
2731 2734
2732 #endif // V8_TARGET_ARCH_IA32 2735 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698