Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 22819011: Fix replaying of captured objects during chunk building. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment by Ben Titzer. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen-escape-analysis.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2422 matching lines...) Expand 10 before | Expand all | Expand 10 after
2433 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) { 2433 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) {
2434 // There are no real uses of the arguments object. 2434 // There are no real uses of the arguments object.
2435 // arguments.length and element access are supported directly on 2435 // arguments.length and element access are supported directly on
2436 // stack arguments, and any real arguments object use causes a bailout. 2436 // stack arguments, and any real arguments object use causes a bailout.
2437 // So this value is never used. 2437 // So this value is never used.
2438 return NULL; 2438 return NULL;
2439 } 2439 }
2440 2440
2441 2441
2442 LInstruction* LChunkBuilder::DoCapturedObject(HCapturedObject* instr) { 2442 LInstruction* LChunkBuilder::DoCapturedObject(HCapturedObject* instr) {
2443 HEnvironment* env = current_block_->last_environment();
2444 instr->ReplayEnvironment(env);
2445
2443 // There are no real uses of a captured object. 2446 // There are no real uses of a captured object.
2444 return NULL; 2447 return NULL;
2445 } 2448 }
2446 2449
2447 2450
2448 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) { 2451 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) {
2449 info()->MarkAsRequiresFrame(); 2452 info()->MarkAsRequiresFrame();
2450 LOperand* args = UseRegister(instr->arguments()); 2453 LOperand* args = UseRegister(instr->arguments());
2451 LOperand* length; 2454 LOperand* length;
2452 LOperand* index; 2455 LOperand* index;
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
2589 2592
2590 2593
2591 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2594 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2592 LOperand* object = UseRegister(instr->object()); 2595 LOperand* object = UseRegister(instr->object());
2593 LOperand* index = UseRegister(instr->index()); 2596 LOperand* index = UseRegister(instr->index());
2594 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2597 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2595 } 2598 }
2596 2599
2597 2600
2598 } } // namespace v8::internal 2601 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-escape-analysis.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698