Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2281873002: Convert LayoutTests/fast/canvas/2d tests to testharness. (Closed)

Created:
4 years, 3 months ago by sivag
Modified:
4 years, 3 months ago
Reviewers:
Srirama, fs, Justin Novosad
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert LayoutTests/fast/canvas/2d tests to testharness. This patch uses testharness.js asserts to test 2d.text.draw.fill.maxWidth.veryLarge.html, 2d.text.draw.fill.maxWidth.verySmall.html. Remove the expectation files as they are not needed any more. BUG=639732 Committed: https://crrev.com/65877dcebcfe05fefc6ecd2c0a765fc924b0bd01 Cr-Commit-Position: refs/heads/master@{#415963}

Patch Set 1 #

Total comments: 1

Messages

Total messages: 11 (5 generated)
sivag
ptal..
4 years, 3 months ago (2016-08-26 10:50:31 UTC) #3
fs
lgtm https://codereview.chromium.org/2281873002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html File third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html (right): https://codereview.chromium.org/2281873002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html#newcode2 third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html:2: <title>Test that color gets applied properly with canvas2d ...
4 years, 3 months ago (2016-08-26 11:05:29 UTC) #4
Justin Novosad
On 2016/08/26 11:05:29, fs wrote: > lgtm > > https://codereview.chromium.org/2281873002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html > File > third_party/WebKit/LayoutTests/fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html > ...
4 years, 3 months ago (2016-09-01 14:22:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281873002/1
4 years, 3 months ago (2016-09-01 14:28:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 15:51:43 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 15:55:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65877dcebcfe05fefc6ecd2c0a765fc924b0bd01
Cr-Commit-Position: refs/heads/master@{#415963}

Powered by Google App Engine
This is Rietveld 408576698