Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2281863002: [compiler] Remove default argument for code flags. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove default argument for code flags. R=bmeurer@chromium.org Committed: https://crrev.com/e53d2acec10bb8a671108b0c1c035079c78ca93d Cr-Commit-Position: refs/heads/master@{#38935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M src/compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-multiple-return.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-field-type-tracking.cc View 5 chunks +10 lines, -5 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
Michael Starzinger
This is mostly to fix GCC compilation. The Code::ComputeFlags method is only available in object-inl.h ...
4 years, 3 months ago (2016-08-26 08:29:15 UTC) #1
marja
lgtm
4 years, 3 months ago (2016-08-26 08:39:56 UTC) #5
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-08-26 08:41:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281863002/1
4 years, 3 months ago (2016-08-26 09:02:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 09:03:46 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 09:04:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e53d2acec10bb8a671108b0c1c035079c78ca93d
Cr-Commit-Position: refs/heads/master@{#38935}

Powered by Google App Engine
This is Rietveld 408576698