Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 228183002: cc: Move ResourcePool ownership to LTHI. (Closed)

Created:
6 years, 8 months ago by reveman
Modified:
6 years, 8 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Move ResourcePool ownership to LTHI. Provides a significant amount of cleanup by removing the requirement to plumb resource format and texture target through the Rasterizer interface. BUG=269841 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263459

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -105 lines) Patch
M cc/resources/direct_raster_worker_pool.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/direct_raster_worker_pool.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M cc/resources/image_raster_worker_pool.h View 1 4 chunks +2 lines, -7 lines 0 comments Download
M cc/resources/image_raster_worker_pool.cc View 1 2 chunks +3 lines, -14 lines 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M cc/resources/prioritized_tile_set_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M cc/resources/raster_worker_pool_perftest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/raster_worker_pool_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/rasterizer.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M cc/resources/resource_pool.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/resources/tile_manager.h View 1 5 chunks +5 lines, -6 lines 0 comments Download
M cc/resources/tile_manager.cc View 1 4 chunks +5 lines, -14 lines 0 comments Download
M cc/resources/tile_manager_perftest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M cc/test/fake_picture_layer_tiling_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_picture_layer_tiling_client.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/test/fake_tile_manager.h View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/test/fake_tile_manager.cc View 1 4 chunks +6 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 7 chunks +29 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
reveman
Please take a look.
6 years, 8 months ago (2014-04-10 20:46:25 UTC) #1
vmpstr
Nice, lgtm
6 years, 8 months ago (2014-04-10 20:55:25 UTC) #2
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 8 months ago (2014-04-10 23:27:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/228183002/20001
6 years, 8 months ago (2014-04-10 23:29:08 UTC) #4
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 8 months ago (2014-04-10 23:48:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/228183002/40001
6 years, 8 months ago (2014-04-10 23:50:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/228183002/40001
6 years, 8 months ago (2014-04-11 23:49:33 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-12 03:07:17 UTC) #8
Message was sent while issue was closed. 
Change committed as 263459

Powered by Google App Engine
This is Rietveld 408576698