Changes client_token to be client_auth_token.

blimp/common/proto/protocol_control.proto

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 
 package blimp;
 
 // Indicates the message-Id that the peer has most-recently processed.
 message CheckpointAckMessage {
   optional int64 checkpoint_id = 1;
 }
 
 // Contains Client->Engine information to establish an authenticated connection.
 message StartConnectionMessage {
-  optional string client_token = 1;
+  optional string client_auth_token = 1;

[maniscalco, 2016/08/30 18:05:09]

I'm not so sure I'd change this proto field name since the value needs to match
the "client_token" returned by the assigner, but I don't feel that strongly at
this point.  Wez, WDYT?

[Wez, 2016/09/01 02:29:26]

My preference would be to rename it here, for consistency with the rest of the
Chromium-side code - then from the Chromium side only the Assigner API field has
the client_token name. Make sense?

[maniscalco, 2016/09/01 14:44:30]

I'm fine with renaming it as well, but just so we're clear things still won't be
fully consistent throughout chromium as there are other chromium places that
refer to it as "client token" that aren't being changed (e.g. the command line
flags).  And, IMO, it's not worth changing those.

[CJ, 2016/09/01 23:18:22]

Acknowledged.

   optional int32 protocol_version = 2;
 }
 
 // Indicates the reason for the peer ending the connection.
 message EndConnectionMessage {
   enum Reason {
     UNKNOWN = 0;
     AUTHENTICATION_FAILED = 1;
     PROTOCOL_MISMATCH = 2;
   };
   optional Reason reason = 1;
 }
 
 message ProtocolControlMessage {
   oneof connection_message {
     // Client => Server types.
     StartConnectionMessage start_connection = 41;
 
     // Bi-directional types.
     CheckpointAckMessage checkpoint_ack = 42;
     EndConnectionMessage end_connection = 43;
   }
 }